public inbox for [email protected]
help / color / mirror / Atom feed pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the
4+ messages / 2 participants
[nested] [flat]
* pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the
@ 2021-02-09 10:58 Akshay Joshi <[email protected]>
2021-02-09 11:21 ` Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Akshay Joshi @ 2021-02-09 10:58 UTC (permalink / raw)
To: [email protected]
Use 'sys.executable' to get the absolute path of the executable binary for the Python interpreter instead of existing complex logic.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53724675697ccdf34b8e6a5da21e9b4fc4d6...
Modified Files
--------------
web/pgadmin/misc/bgprocess/processes.py | 89 +--------------------------------
1 file changed, 1 insertion(+), 88 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the
2021-02-09 10:58 pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Akshay Joshi <[email protected]>
@ 2021-02-09 11:21 ` Murtuza Zabuawala <[email protected]>
2021-02-09 14:07 ` Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Akshay Joshi <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Murtuza Zabuawala @ 2021-02-09 11:21 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers <[email protected]>
Hi,
It will break the WSGI.
--
Regards,
Murtuza Zabuawala
*EDB*
*POWER TO POSTGRES*
https://www.edbpostgres.com
On Tue, Feb 9, 2021 at 4:28 PM Akshay Joshi <[email protected]>
wrote:
> Use 'sys.executable' to get the absolute path of the executable binary for
> the Python interpreter instead of existing complex logic.
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53724675697ccdf34b8e6a5da21e9b4fc4d6...
>
> Modified Files
> --------------
> web/pgadmin/misc/bgprocess/processes.py | 89
> +--------------------------------
> 1 file changed, 1 insertion(+), 88 deletions(-)
>
>
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the
2021-02-09 10:58 pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Akshay Joshi <[email protected]>
2021-02-09 11:21 ` Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Murtuza Zabuawala <[email protected]>
@ 2021-02-09 14:07 ` Akshay Joshi <[email protected]>
2021-02-09 14:45 ` Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Akshay Joshi @ 2021-02-09 14:07 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers <[email protected]>
Hi Murtuza/Hackers
On Tue, Feb 9, 2021 at 4:51 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> It will break the WSGI.
>
I have tested pgAdmin4 using the following combination:
- Python wheel package + Apache (WSGI) on Ubuntu 18.04 (Fresh VM)
- APT https://www.pgadmin.org/download/pgadmin-4-apt/ on Ubuntu 18.04
(Fresh VM)
I have made the code changes after installation, use sys.executable, and
then restart the apache in both the above test scenario. All the
utilities(Backup, Maintainance, etc...) working absolutely fine. Please
refer to the below screenshot
[image: pgAdmin_APT.png]
Am I missing some scenario? If any specific test scenario that I missed
please let me know so that I'll figure out some solution.
>
> --
> Regards,
> Murtuza Zabuawala
> *EDB*
> *POWER TO POSTGRES*
> https://www.edbpostgres.com
>
>
> On Tue, Feb 9, 2021 at 4:28 PM Akshay Joshi <[email protected]>
> wrote:
>
>> Use 'sys.executable' to get the absolute path of the executable binary
>> for the Python interpreter instead of existing complex logic.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53724675697ccdf34b8e6a5da21e9b4fc4d6...
>>
>> Modified Files
>> --------------
>> web/pgadmin/misc/bgprocess/processes.py | 89
>> +--------------------------------
>> 1 file changed, 1 insertion(+), 88 deletions(-)
>>
>>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
Attachments:
[image/png] pgAdmin_APT.png (474.9K, 3-pgAdmin_APT.png)
download | view image
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the
2021-02-09 10:58 pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Akshay Joshi <[email protected]>
2021-02-09 11:21 ` Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Murtuza Zabuawala <[email protected]>
2021-02-09 14:07 ` Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Akshay Joshi <[email protected]>
@ 2021-02-09 14:45 ` Murtuza Zabuawala <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Murtuza Zabuawala @ 2021-02-09 14:45 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers <[email protected]>
Hi,
On Tue, Feb 9, 2021 at 7:37 PM Akshay Joshi <[email protected]>
wrote:
> Hi Murtuza/Hackers
>
> On Tue, Feb 9, 2021 at 4:51 PM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> It will break the WSGI.
>>
>
> I have tested pgAdmin4 using the following combination:
>
> - Python wheel package + Apache (WSGI) on Ubuntu 18.04 (Fresh VM)
> - APT https://www.pgadmin.org/download/pgadmin-4-apt/ on Ubuntu 18.04
> (Fresh VM)
>
> I have made the code changes after installation, use sys.executable,
> and then restart the apache in both the above test scenario. All the
> utilities(Backup, Maintainance, etc...) working absolutely fine. Please
> refer to the below screenshot
>
> [image: pgAdmin_APT.png]
>
> Am I missing some scenario? If any specific test scenario that I missed
> please let me know so that I'll figure out some solution.
>
I don't remember the exact scenario/steps but AFAIR we rewrote that logic
to handle scenario when we run pgAdmin4 under WSGI and/or on Windows, It
was using the wrong python path to execute the process executor.
-- Murtuza
>
>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>>
>> On Tue, Feb 9, 2021 at 4:28 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Use 'sys.executable' to get the absolute path of the executable binary
>>> for the Python interpreter instead of existing complex logic.
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>>
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53724675697ccdf34b8e6a5da21e9b4fc4d6...
>>>
>>> Modified Files
>>> --------------
>>> web/pgadmin/misc/bgprocess/processes.py | 89
>>> +--------------------------------
>>> 1 file changed, 1 insertion(+), 88 deletions(-)
>>>
>>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Attachments:
[image/png] pgAdmin_APT.png (474.9K, 3-pgAdmin_APT.png)
download | view image
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2021-02-09 14:45 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-09 10:58 pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Akshay Joshi <[email protected]>
2021-02-09 11:21 ` Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Murtuza Zabuawala <[email protected]>
2021-02-09 14:07 ` Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Akshay Joshi <[email protected]>
2021-02-09 14:45 ` Re: pgAdmin 4 commit: Use 'sys.executable' to get the absolute path of the Murtuza Zabuawala <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox