public inbox for [email protected]  

help / color / mirror / Atom feed
From: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: Robert Eckhardt <[email protected]>
Cc: Joao De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode
Date: Tue, 27 Mar 2018 15:55:18 +0530
Message-ID: <CAKKotZSG=4Z2PFs_sE7kgON=BEtot3R599iWYK3_ZCKiEkTLjg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoxZmCwSHg_bbP6WjJQhgu01eEqP=Y4ZyXAcWhtb+Q91wQ@mail.gmail.com>
References: <CAKKotZTzsN7Duyb5KpVuVHBK9pGHXLNvrp7JRVJ1uetAEYhuKg@mail.gmail.com>
	<CA+OCxoxj2Jp0iaJw4TmRWE4Yz3ZwpF47n7agoeq8rR5MaNhyig@mail.gmail.com>
	<CAKKotZSf=7iBb3db3aYvmYpA081tjcsxcSyApVe_y8b4d+7q+Q@mail.gmail.com>
	<CAE+jjakMz=G-gj_u9pQ4wUcbaF5=kdBTz1R25Cb3iavLyEuJMg@mail.gmail.com>
	<CAAtBm9V+y-xTCQvTzQ6tnGoB77fKRsVKdqeq+b+9GzvQ_Cmfsw@mail.gmail.com>
	<CA+OCxoxZmCwSHg_bbP6WjJQhgu01eEqP=Y4ZyXAcWhtb+Q91wQ@mail.gmail.com>

On Tue, Mar 27, 2018 at 3:13 PM, Dave Page <[email protected]> wrote:

>
>
> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt <[email protected]>
> wrote:
>
>>
>>
>> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> @Murtuza: The patch codewise looks good. Nice to see that we are using
>>> axios instead of jquery ajax calls and that there is some coverage for the
>>> change.
>>> Nevertheless the Javascript testing looks a bit slim and could be
>>> improved. Also the DataSorting class could have some other member functions
>>> like the model validation could be extracted out so that it is easily
>>> tested.
>>>
>>>
>>> @Hackers: This was how we tried to test this feature:
>>> 1 - Started pgAdmin
>>> 2 - Opened the query tool for a specific server
>>> 3 - Executed a SQL statment
>>> 4 - Pressed the column header to try to order, nothing happened
>>> 5 - Right clicked the column header to see if it was there the option,
>>> nothing
>>>
>>> This is the behavior that we were expecting, not to have to open Data
>>> View and then press the icon that is not even near the grid in order to
>>> sort the column. Is this really the way we want people to use the grid in
>>> pgAdmin? Should it be more intuitive?
>>>
>>
>> Have we considered making the grid behave more like excel or other grids?
>> I think that having the ascending and descending inside the column header,
>> we could similarly provide filtering. Something that would give users a
>> more intuitive place to look.
>>
>
> Doing the sorting via header clicks is convenient but very restrictive.
> How do you specify multiple columns to sort by for example? The current
> design allows you to select columns and the sort order as you see fit.
>

Another reason we can't use that because w
e have already occupied that behaviour for selecting entire column
​ when user clicks on header.
As Dave suggested, I will be merging it with filter dialog meaning it will
be accessible via direct button on toolbar & keyboard shortcut.​
​

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


view thread (25+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode
  In-Reply-To: <CAKKotZSG=4Z2PFs_sE7kgON=BEtot3R599iWYK3_ZCKiEkTLjg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox