public inbox for [email protected]  

help / color / mirror / Atom feed
From: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: Surinder Kumar <[email protected]>
Cc: Robert Eckhardt <[email protected]>
Cc: Shruti B Iyer <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Matthew Kleiman <[email protected]>
Subject: Re: [pgAdmin4][PATCH] Consolidating gray colors in the application
Date: Thu, 8 Jun 2017 10:48:25 +0530
Message-ID: <CAKKotZST7Ph2PgRSzm6XFN5NOnApKTH2L0j7BO_V1N7HFKGbmg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxox024g-VkUTGetuZkFa-yT8pt_mxqUtkZcg0fNABqLTWg@mail.gmail.com>
References: <CACrUwh+GDxb0mMtJkF-EoNu6L8hzAgN4qUp5fEn_sdWH9i3KeQ@mail.gmail.com>
	<CA+OCxoypX_QdJjhmkAiJtg34oOP7GAwb58WQYQX0O-h_0uT8MA@mail.gmail.com>
	<CAM5-9D8sSJL3mFV65MnwTtgdW=ySUROgp01G+=oHeeTUxPpa8g@mail.gmail.com>
	<CA+OCxozQSbXRsjRqVxRQ8Bm_PYSv2_YOpcw7EwzBLVdmVOtvLw@mail.gmail.com>
	<CAM5-9D97E8_H1_9OHmVCvP8KBPCwwXMZN_CmUHuPgf72m_ju1Q@mail.gmail.com>
	<CAAtBm9UjhRP9Un=KsjMr11fELMBphQ9u9jDa7u9hj=J8ORDmBQ@mail.gmail.com>
	<CAM5-9D__jp-b=M72NDNzN-405BTtAp99j_4Hhv268a_bzYayHg@mail.gmail.com>
	<CA+OCxox024g-VkUTGetuZkFa-yT8pt_mxqUtkZcg0fNABqLTWg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hello,

I think we could have use some different grey colour shade for SlickGrid
headers from wcDocker panel, It does not look bad but as a end user I'm not
able to differentiate between them now, please refer screenshot attached.

Is this expected with new design style?

[image: Inline image 1]


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 7, 2017 at 9:01 PM, Dave Page <[email protected]> wrote:

> Thanks, applied.
>
> On Wed, Jun 7, 2017 at 3:48 PM, Surinder Kumar
> <[email protected]> wrote:
> > Hi
> >
> > I have used classes 'bg-gray-2 border-gray-3' for styling header and
> footer
> > of properties panel which are also used in other places.
> >
> > Please find attached patch.
> >
> >
> > On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt <[email protected]>
> > wrote:
> >>
> >> Thank you.
> >>
> >> -- Rob
> >>
> >> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar
> >> <[email protected]> wrote:
> >>>
> >>> Sure I will send.
> >>>
> >>> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <[email protected]> wrote:
> >>>>
> >>>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
> >>>> <[email protected]> wrote:
> >>>> > Hi
> >>>> >
> >>>> > With the latest pull, I found:
> >>>> > The header color of Properties panel disappears and background color
> >>>> > of
> >>>> > footer area in Edit Properties panel is changed.
> >>>>
> >>>> Oh, I missed that :-(. Can you come up with a quick fix using the new
> >>>> classes?
> >>>>
> >>>> --
> >>>> Dave Page
> >>>> Blog: http://pgsnake.blogspot.com
> >>>> Twitter: @pgsnake
> >>>>
> >>>> EnterpriseDB UK: http://www.enterprisedb.com
> >>>> The Enterprise PostgreSQL Company
> >>>
> >>>
> >>
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [image/png] image.png (57.4K, 3-image.png)
  download | view image

  [image/png] Screen Shot 2017-06-08 at 10.36.29 am.png (61.2K, 4-Screen%20Shot%202017-06-08%20at%2010.36.29%20am.png)
  download | view image

view thread (11+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][PATCH] Consolidating gray colors in the application
  In-Reply-To: <CAKKotZST7Ph2PgRSzm6XFN5NOnApKTH2L0j7BO_V1N7HFKGbmg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox