public inbox for [email protected]
help / color / mirror / Atom feedFrom: Surinder Kumar <[email protected]>
To: Robert Eckhardt <[email protected]>
Cc: Dave Page <[email protected]>
Cc: Shruti B Iyer <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Matthew Kleiman <[email protected]>
Subject: Re: [pgAdmin4][PATCH] Consolidating gray colors in the application
Date: Wed, 7 Jun 2017 20:18:18 +0530
Message-ID: <CAM5-9D__jp-b=M72NDNzN-405BTtAp99j_4Hhv268a_bzYayHg@mail.gmail.com> (raw)
In-Reply-To: <CAAtBm9UjhRP9Un=KsjMr11fELMBphQ9u9jDa7u9hj=J8ORDmBQ@mail.gmail.com>
References: <CACrUwh+GDxb0mMtJkF-EoNu6L8hzAgN4qUp5fEn_sdWH9i3KeQ@mail.gmail.com>
<CA+OCxoypX_QdJjhmkAiJtg34oOP7GAwb58WQYQX0O-h_0uT8MA@mail.gmail.com>
<CAM5-9D8sSJL3mFV65MnwTtgdW=ySUROgp01G+=oHeeTUxPpa8g@mail.gmail.com>
<CA+OCxozQSbXRsjRqVxRQ8Bm_PYSv2_YOpcw7EwzBLVdmVOtvLw@mail.gmail.com>
<CAM5-9D97E8_H1_9OHmVCvP8KBPCwwXMZN_CmUHuPgf72m_ju1Q@mail.gmail.com>
<CAAtBm9UjhRP9Un=KsjMr11fELMBphQ9u9jDa7u9hj=J8ORDmBQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi
I have used classes 'bg-gray-2 border-gray-3' for styling header and footer
of properties panel which are also used in other places.
Please find attached patch.
On Wed, Jun 7, 2017 at 6:59 PM, Robert Eckhardt <[email protected]>
wrote:
> Thank you.
>
> -- Rob
>
> On Wed, Jun 7, 2017 at 9:28 AM, Surinder Kumar <
> [email protected]> wrote:
>
>> Sure I will send.
>>
>> On Wed, Jun 7, 2017 at 6:54 PM, Dave Page <[email protected]> wrote:
>>
>>> On Wed, Jun 7, 2017 at 2:22 PM, Surinder Kumar
>>> <[email protected]> wrote:
>>> > Hi
>>> >
>>> > With the latest pull, I found:
>>> > The header color of Properties panel disappears and background color of
>>> > footer area in Edit Properties panel is changed.
>>>
>>> Oh, I missed that :-(. Can you come up with a quick fix using the new
>>> classes?
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] apply_color_to_properties_header_footer_panel.patch (876B, 3-apply_color_to_properties_header_footer_panel.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js
index 4166911..14a3383 100644
--- a/web/pgadmin/browser/templates/browser/js/node.js
+++ b/web/pgadmin/browser/templates/browser/js/node.js
@@ -1003,7 +1003,7 @@ define([
}
});
- createButtons(buttons, 'header', 'pg-prop-btn-group-above');
+ createButtons(buttons, 'header', 'pg-prop-btn-group-above bg-gray-2 border-gray-3');
}
j.append(content);
}.bind(panel),
@@ -1243,7 +1243,7 @@ define([
setTimeout(function() { editFunc.call(); }, 0);
});
}
- }],'footer' ,'pg-prop-btn-group-below');
+ }],'footer' ,'pg-prop-btn-group-below bg-gray-2 border-gray-3');
};
// Create status bar.
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][PATCH] Consolidating gray colors in the application
In-Reply-To: <CAM5-9D__jp-b=M72NDNzN-405BTtAp99j_4Hhv268a_bzYayHg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox