public inbox for [email protected]  

help / color / mirror / Atom feed
From: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [RM#4906][pgAdmin4] Fix context menu keyboard shortcut issue with Firefox
Date: Thu, 7 Nov 2019 16:13:34 +0530
Message-ID: <CAKKotZSkn+32uiD2aO-=LF0JgdXPO6cBeaY_oC-4TSesNxRinQ@mail.gmail.com> (raw)

Hello,

PFA patch to fix the issue where keyboard shortcut for context menu is not
working when using Firefox on CestOS7.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Attachments:

  [application/octet-stream] RM_4906.diff (807B, 3-RM_4906.diff)
  download | inline diff:
diff --git a/web/pgadmin/browser/static/js/keyboard.js b/web/pgadmin/browser/static/js/keyboard.js
index 1a402da8d..ba1a7806d 100644
--- a/web/pgadmin/browser/static/js/keyboard.js
+++ b/web/pgadmin/browser/static/js/keyboard.js
@@ -307,8 +307,9 @@ _.extend(pgBrowser.keyboardNavigation, {
   },
   bindContextMenu: function(event) {
     const tree = this.getTreeDetails();
-    const left = $(event.srcElement).find('.aciTreeEntry').position().left + 70;
-    const top = $(event.srcElement).find('.aciTreeEntry').position().top + 70;
+    let _srcElement = event.srcElement || event.target;
+    const left = $(_srcElement).find('.aciTreeEntry').position().left + 70;
+    const top = $(_srcElement).find('.aciTreeEntry').position().top + 70;
 
     tree.t.blur(tree.i);
     $('#tree').trigger('blur');


view thread (2+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [RM#4906][pgAdmin4] Fix context menu keyboard shortcut issue with Firefox
  In-Reply-To: <CAKKotZSkn+32uiD2aO-=LF0JgdXPO6cBeaY_oC-4TSesNxRinQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox