public inbox for [email protected]
help / color / mirror / Atom feed[RM#4906][pgAdmin4] Fix context menu keyboard shortcut issue with Firefox
2+ messages / 2 participants
[nested] [flat]
* [RM#4906][pgAdmin4] Fix context menu keyboard shortcut issue with Firefox
@ 2019-11-07 10:43 Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Murtuza Zabuawala @ 2019-11-07 10:43 UTC (permalink / raw)
To: pgadmin-hackers
Hello,
PFA patch to fix the issue where keyboard shortcut for context menu is not
working when using Firefox on CestOS7.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[application/octet-stream] RM_4906.diff (807B, 3-RM_4906.diff)
download | inline diff:
diff --git a/web/pgadmin/browser/static/js/keyboard.js b/web/pgadmin/browser/static/js/keyboard.js
index 1a402da8d..ba1a7806d 100644
--- a/web/pgadmin/browser/static/js/keyboard.js
+++ b/web/pgadmin/browser/static/js/keyboard.js
@@ -307,8 +307,9 @@ _.extend(pgBrowser.keyboardNavigation, {
},
bindContextMenu: function(event) {
const tree = this.getTreeDetails();
- const left = $(event.srcElement).find('.aciTreeEntry').position().left + 70;
- const top = $(event.srcElement).find('.aciTreeEntry').position().top + 70;
+ let _srcElement = event.srcElement || event.target;
+ const left = $(_srcElement).find('.aciTreeEntry').position().left + 70;
+ const top = $(_srcElement).find('.aciTreeEntry').position().top + 70;
tree.t.blur(tree.i);
$('#tree').trigger('blur');
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [RM#4906][pgAdmin4] Fix context menu keyboard shortcut issue with Firefox
@ 2019-11-08 13:12 Akshay Joshi <[email protected]>
parent: Murtuza Zabuawala <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2019-11-08 13:12 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Thu, Nov 7, 2019 at 4:13 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hello,
>
> PFA patch to fix the issue where keyboard shortcut for context menu is not
> working when using Firefox on CestOS7.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-11-08 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 10:43 [RM#4906][pgAdmin4] Fix context menu keyboard shortcut issue with Firefox Murtuza Zabuawala <[email protected]>
2019-11-08 13:12 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox