public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: To fix the issue in Debugger module (pgAdmin4)
Date: Fri, 7 Oct 2016 17:12:55 +0530
Message-ID: <CAKKotZSrWzCVBbuywF8VFGMtMK-VdT=fyo_3gY97OnoO7hZspw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoymEzDsLaABZixOjQ37jJdP1J7+xJ6By_oJHi=2bSRoRg@mail.gmail.com>
References: <CAKKotZQz6mGEiky_Szo91tzm_RFvwJTYGriTmuxVYrhcWi5nJg@mail.gmail.com>
<CA+OCxoxkphr1YF6F53j3sTreTMvoBOKqV+wjF6CnxoQ-SA+rzA@mail.gmail.com>
<CAKKotZRMetEEPzFTuqiw_8Vit2_STHSN22=K+5frJBu7=Jp6PQ@mail.gmail.com>
<CAKKotZQGdhiFrtNK0xz8OVLKOA2QCk_yfOZDFT+HEMfELzbk4A@mail.gmail.com>
<CA+OCxoyzS4_cST0qJ7CbmxqOry4wGZCQkoiLpcXgjr2N4snPQw@mail.gmail.com>
<CAKKotZSjyeZT_bS8_No-cEftRjqPPptLx+zV2+_DqV=KYZYRcw@mail.gmail.com>
<CA+OCxoyLMvyRpPSMztrUf0st7yGvyeYquOmyFabQzg6Czieh=Q@mail.gmail.com>
<CAKKotZRW4WF2gsaPu-cRZJmrAia0GiDTOhwDKQdUpBC5VRoVjQ@mail.gmail.com>
<CA+OCxoyF37xc+S4=r37KRAEh+zUfN4-WBSSv1YSe1VZpMmNfkg@mail.gmail.com>
<CAKKotZSz3kgLYGNyu_BGORF+J=F2qmLa-2z9Rzq1HgSjXjTyZg@mail.gmail.com>
<CA+OCxoymEzDsLaABZixOjQ37jJdP1J7+xJ6By_oJHi=2bSRoRg@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Dave,
I faced the same issue when I initially tried that, but then as per Neel
suggestion I changed SELECT pg_sleep() to PERFORM pg_sleep() in function.
You will face the same in pgAdmin3 if you use select pg_sleep() in your
function the debug call never returns from DB server.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Oct 7, 2016 at 4:16 PM, Dave Page <[email protected]> wrote:
> Hi
>
> It still seems buggy. I started debugging list_emp() from our sample
> DB, and just hit Step Into a few times randomly. It got as far as the
> pg_sleep call I added, then never returned so I couldn't proceed. See
> attached screenshot.
>
>
> On Thu, Oct 6, 2016 at 10:05 AM, Murtuza Zabuawala
> <[email protected]> wrote:
> > Hi Dave,
> >
> > PFA updated patch with suggestion given.
> >
> > --
> > Regards,
> > Murtuza Zabuawala
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> > On Wed, Oct 5, 2016 at 7:29 PM, Dave Page <[email protected]> wrote:
> >>
> >> OK, that's much better. I think I've figured out what's causing the
> >> remaining execution error as well - we're not disabling the buttons
> >> until we get a response from the server, so if you click too quickly,
> >> you make multiple requests at once. I tested this by adding a "SELECT
> >> pg_sleep(2);" to a loop in a function.
> >>
> >> If you can fix that as well, then I think we can call this issue fixed.
> >>
> >> Thanks!
> >>
> >> On Wed, Oct 5, 2016 at 1:09 PM, Murtuza Zabuawala
> >> <[email protected]> wrote:
> >> > Hi Dave,
> >> >
> >> > PFA updated patch for the same.
> >> > RM#1227
> >> >
> >> > Please review.
> >> >
> >> >
> >> > --
> >> > Regards,
> >> > Murtuza Zabuawala
> >> > EnterpriseDB: http://www.enterprisedb.com
> >> > The Enterprise PostgreSQL Company
> >> >
> >> > On Mon, Oct 3, 2016 at 6:05 PM, Dave Page <[email protected]> wrote:
> >> >>
> >> >> Hi
> >> >>
> >> >> On Tue, Sep 27, 2016 at 7:40 AM, Murtuza Zabuawala
> >> >> <[email protected]> wrote:
> >> >> > Hi Dave,
> >> >> >
> >> >> > PFA updated patch to fix mentioned issue as well as incremental
> msgs
> >> >> > updates
> >> >> > in Messages Tab.
> >> >>
> >> >> This doesn't seem to work well. In pgAdmin 4 I get the following:
> >> >>
> >> >> ====
> >> >> SELECT 1
> >> >> INFO: EMPNO ENAME
> >> >>
> >> >>
> >> >> INFO: ----- -------
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7369 SMITH
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7499 ALLEN
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7521 WARD
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7566 JONES
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7654 MARTIN
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> INFO: 7698 BLAKE
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7782 CLARK
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7788 SCOTT
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7839 KING
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7844 TURNER
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7876 ADAMS
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> INFO: 7900 JAMES
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7902 FORD
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> INFO: 7934 MILLER
> >> >>
> >> >>
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> SELECT 1
> >> >> ====
> >> >>
> >> >> Whilst in pgAdmin III I get:
> >> >>
> >> >> ====
> >> >> INFO: EMPNO ENAME
> >> >> INFO: ----- -------
> >> >> INFO: 7369 SMITH
> >> >> INFO: 7499 ALLEN
> >> >> INFO: 7521 WARD
> >> >> INFO: 7566 JONES
> >> >> INFO: 7654 MARTIN
> >> >> INFO: 7698 BLAKE
> >> >> INFO: 7782 CLARK
> >> >> INFO: 7788 SCOTT
> >> >> INFO: 7839 KING
> >> >> INFO: 7844 TURNER
> >> >> INFO: 7876 ADAMS
> >> >> INFO: 7900 JAMES
> >> >> INFO: 7902 FORD
> >> >> INFO: 7934 MILLER
> >> >> SELECT 1
> >> >> ====
> >> >>
> >> >> Sidenote: pgAdmin III uses a fixed-width font for this output which
> >> >> works far better than pgAdmin 4's variable width font.
> >> >>
> >> >> --
> >> >> Dave Page
> >> >> Blog: http://pgsnake.blogspot.com
> >> >> Twitter: @pgsnake
> >> >>
> >> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> >> The Enterprise PostgreSQL Company
> >> >
> >> >
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
view thread (21+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PATCH: To fix the issue in Debugger module (pgAdmin4)
In-Reply-To: <CAKKotZSrWzCVBbuywF8VFGMtMK-VdT=fyo_3gY97OnoO7hZspw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox