public inbox for [email protected]  

help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: PATCH: Fixes issue where executing a query disables the Save button in the query tool (pgAdmin4)
Date: Wed, 14 Sep 2016 14:33:26 +0530
Message-ID: <CAKKotZSw=FBbPCuboKKaiOQf=nS+5vNwztqiaSOF9Uq8VqqYEw@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

PFA minor patch to fix the issue where executing a query disables the Save
button in the query tool
RM#1695

Please review.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] RM_1695.patch (887B, 3-RM_1695.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 402c316..9de292d 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -1709,8 +1709,10 @@ define(
 
           // Initial settings for delete row, copy row and paste row buttons.
           $("#btn-delete-row").prop('disabled', true);
-          if (!self.can_edit) {
+          // Do not disable save button in query tool
+          if(!self.is_query_tool && !self.can_edit)
             $("#btn-save").prop('disabled', true);
+          if (!self.can_edit) {
             $("#btn-file-menu-dropdown").prop('disabled', true);
             $("#btn-delete-row").prop('disabled', true);
             $("#btn-copy-row").prop('disabled', true);

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: PATCH: Fixes issue where executing a query disables the Save button in the query tool (pgAdmin4)
  In-Reply-To: <CAKKotZSw=FBbPCuboKKaiOQf=nS+5vNwztqiaSOF9Uq8VqqYEw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox