public inbox for [email protected]
help / color / mirror / Atom feedPATCH: Fixes issue where executing a query disables the Save button in the query tool (pgAdmin4)
2+ messages / 2 participants
[nested] [flat]
* PATCH: Fixes issue where executing a query disables the Save button in the query tool (pgAdmin4)
@ 2016-09-14 09:03 Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Murtuza Zabuawala @ 2016-09-14 09:03 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA minor patch to fix the issue where executing a query disables the Save
button in the query tool
RM#1695
Please review.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] RM_1695.patch (887B, 3-RM_1695.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 402c316..9de292d 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -1709,8 +1709,10 @@ define(
// Initial settings for delete row, copy row and paste row buttons.
$("#btn-delete-row").prop('disabled', true);
- if (!self.can_edit) {
+ // Do not disable save button in query tool
+ if(!self.is_query_tool && !self.can_edit)
$("#btn-save").prop('disabled', true);
+ if (!self.can_edit) {
$("#btn-file-menu-dropdown").prop('disabled', true);
$("#btn-delete-row").prop('disabled', true);
$("#btn-copy-row").prop('disabled', true);
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: PATCH: Fixes issue where executing a query disables the Save button in the query tool (pgAdmin4)
@ 2016-09-14 10:23 Dave Page <[email protected]>
parent: Murtuza Zabuawala <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2016-09-14 10:23 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Thanks - applied with a minor change to treat the save drop-down menu
button in the same way as the save button itself.
On Wed, Sep 14, 2016 at 10:03 AM, Murtuza Zabuawala
<[email protected]> wrote:
> Hi,
>
> PFA minor patch to fix the issue where executing a query disables the Save
> button in the query tool
> RM#1695
>
> Please review.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-09-14 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 09:03 PATCH: Fixes issue where executing a query disables the Save button in the query tool (pgAdmin4) Murtuza Zabuawala <[email protected]>
2016-09-14 10:23 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox