public inbox for [email protected]  

help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node
Date: Sat, 9 Jun 2018 23:31:55 +0530
Message-ID: <CAKKotZT9XfAqqgNWVdiMJsaoJ6M854mXs0_HnEN6Y=FDw=7aXQ@mail.gmail.com> (raw)

Hi Dave,

Sorry, the previous patch had a typo, Here's an updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jun 7, 2018 at 2:32 PM, Dave Page <[email protected]> wrote:

> Hi
>
> On Wed, Jun 6, 2018 at 6:04 PM, Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA minor patch to fix the regression issue introduced with RM#3271
>> commit due to which label is not displaying under the graphical explain
>> node, I've attached the screenshot in RM for your reference.
>>
>
> I see the labels, but the popups are not displaying on mouseover/hover
> like they used to. Can you look into that please?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


Attachments:

  [application/octet-stream] RM_3404_v1.diff (816B, 3-RM_3404_v1.diff)
  download | inline diff:
diff --git a/web/pgadmin/misc/static/explain/js/explain.js b/web/pgadmin/misc/static/explain/js/explain.js
index 61cf8f9..e028774 100644
--- a/web/pgadmin/misc/static/explain/js/explain.js
+++ b/web/pgadmin/misc/static/explain/js/explain.js
@@ -576,7 +576,7 @@ define('pgadmin.misc.explain', [
 
       // Draw tooltip
       var image_data = this.toJSON();
-      image.on('mouseover',() => {
+      image.mouseover(() => {
 
         // Empty the tooltip content if it has any and add new data
         toolTipContainer.empty();
@@ -618,7 +618,7 @@ define('pgadmin.misc.explain', [
       });
 
       // Remove tooltip when mouse is out from node's area
-      image.on('mouseout',() => {
+      image.mouseout(() => {
         toolTipContainer.empty();
         toolTipContainer.css({
           'opacity': '0',

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node
  In-Reply-To: <CAKKotZT9XfAqqgNWVdiMJsaoJ6M854mXs0_HnEN6Y=FDw=7aXQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox