public inbox for [email protected]  

help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: PATCH: To fix condition checking (pgAdmin4)
Date: Wed, 14 Sep 2016 16:18:12 +0530
Message-ID: <CAKKotZTKWt4DLH_fkE0bS4-LPJosJt1qXNF6-pcZvxJcFxxN0w@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

PFA minor patch to fix condition checking which was went into code with
commit: 4ba8f4830bcdd8a9085b212

Thanks to Surinder for pointing out.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] fixed_condition_checking.patch (552B, 3-fixed_condition_checking.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/pgadmin.js b/web/pgadmin/static/js/pgadmin.js
index 89da45d..414e7b8 100644
--- a/web/pgadmin/static/js/pgadmin.js
+++ b/web/pgadmin/static/js/pgadmin.js
@@ -42,7 +42,7 @@
 
     // If object is of column type then do not sort
     if (options.hasOwnProperty("_type") && options._type &&
-        (options._type != 'column' || options._type != 'catalog_object_column'))
+        (options._type == 'column' || options._type == 'catalog_object_column'))
       return 0;
 
     // first try and sort Hex codes or Dates

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: PATCH: To fix condition checking (pgAdmin4)
  In-Reply-To: <CAKKotZTKWt4DLH_fkE0bS4-LPJosJt1qXNF6-pcZvxJcFxxN0w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox