public inbox for [email protected]
help / color / mirror / Atom feedPATCH: To fix condition checking (pgAdmin4)
2+ messages / 2 participants
[nested] [flat]
* PATCH: To fix condition checking (pgAdmin4)
@ 2016-09-14 10:48 Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Murtuza Zabuawala @ 2016-09-14 10:48 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA minor patch to fix condition checking which was went into code with
commit: 4ba8f4830bcdd8a9085b212
Thanks to Surinder for pointing out.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] fixed_condition_checking.patch (552B, 3-fixed_condition_checking.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/pgadmin.js b/web/pgadmin/static/js/pgadmin.js
index 89da45d..414e7b8 100644
--- a/web/pgadmin/static/js/pgadmin.js
+++ b/web/pgadmin/static/js/pgadmin.js
@@ -42,7 +42,7 @@
// If object is of column type then do not sort
if (options.hasOwnProperty("_type") && options._type &&
- (options._type != 'column' || options._type != 'catalog_object_column'))
+ (options._type == 'column' || options._type == 'catalog_object_column'))
return 0;
// first try and sort Hex codes or Dates
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: PATCH: To fix condition checking (pgAdmin4)
@ 2016-09-14 11:34 Dave Page <[email protected]>
parent: Murtuza Zabuawala <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2016-09-14 11:34 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Oops, missed that :-(. Thanks, applied.
On Wed, Sep 14, 2016 at 11:48 AM, Murtuza Zabuawala
<[email protected]> wrote:
> Hi,
>
> PFA minor patch to fix condition checking which was went into code with
> commit: 4ba8f4830bcdd8a9085b212
>
> Thanks to Surinder for pointing out.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-09-14 11:34 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 10:48 PATCH: To fix condition checking (pgAdmin4) Murtuza Zabuawala <[email protected]>
2016-09-14 11:34 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox