public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][RM#4942] Fix chrome driver download utility for Ubuntu platform.
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][RM#4942] Fix chrome driver download utility for Ubuntu platform.
@ 2020-03-11 10:07 Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Murtuza Zabuawala @ 2020-03-11 10:07 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA patch to fix the issue with chrome driver download utility due to which
it was failing on Ubuntu 18.04 with following error.
(venv3_pg) murtuza@ubuntu:~/projects/pgadmin4/tools (master)$ python
get_chromedriver.py /opt/google/chrome/chrome /tmp
The specified Chrome executable output an unexpected version string: Google
Chrome 80.0.3987.132 unknown
.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[application/octet-stream] RM_4942.diff (768B, 3-RM_4942.diff)
download | inline diff:
diff --git a/tools/get_chromedriver.py b/tools/get_chromedriver.py
index 48c6cc131..01bfff306 100644
--- a/tools/get_chromedriver.py
+++ b/tools/get_chromedriver.py
@@ -102,6 +102,11 @@ def get_chrome_version(args):
print('The specified Chrome executable output an unexpected '
'version string: {}.'.format(version_str))
sys.exit(1)
+ # On some linux distro `chrome--version` gives output like
+ # 'Google Chrome 80.0.3987.132 unknown\n'
+ # so we need to check and remove the unknown string from the version
+ if version_str.endswith("unknown\n"):
+ version_str = version_str.strip("unknown\n").strip()
chrome_version = '.'.join(version_str.split()[-1].split('.')[:-1])
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][RM#4942] Fix chrome driver download utility for Ubuntu platform.
@ 2020-03-12 05:48 Akshay Joshi <[email protected]>
parent: Murtuza Zabuawala <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2020-03-12 05:48 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Wed, Mar 11, 2020 at 3:38 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA patch to fix the issue with chrome driver download utility due to
> which it was failing on Ubuntu 18.04 with following error.
>
> (venv3_pg) murtuza@ubuntu:~/projects/pgadmin4/tools (master)$ python
> get_chromedriver.py /opt/google/chrome/chrome /tmp
> The specified Chrome executable output an unexpected version string:
> Google Chrome 80.0.3987.132 unknown
> .
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2020-03-12 05:48 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 10:07 [pgAdmin4][RM#4942] Fix chrome driver download utility for Ubuntu platform. Murtuza Zabuawala <[email protected]>
2020-03-12 05:48 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox