public inbox for [email protected]
help / color / mirror / Atom feedFrom: Shubham Agarwal <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgadmin_page functions updated
Date: Fri, 15 Jun 2018 11:33:32 +0530
Message-ID: <CAKbCA9Q2Dyr7UAt6b6trk-7C2_088G2nBKznOh2gZVB2CndPSQ@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELcp=g9qyFwOc_4vejbu3TRCC3a0bTYyajifNc5Z8oj7TQ@mail.gmail.com>
References: <CAKbCA9Rk0PKsMxC95MJhqK=WeDWoizDKiXBZar+uuRe42obq3Q@mail.gmail.com>
<CAFOhELcp=g9qyFwOc_4vejbu3TRCC3a0bTYyajifNc5Z8oj7TQ@mail.gmail.com>
Hi Khushboo,
Yes i agree, currently we are not changing the functions that are already
written but will use css selectors in all the upcoming new test cases.
Thanks and regards,
Shubham Agarwal
On Fri, Jun 15, 2018 at 11:02 AM, Khushboo Vashi <
[email protected]> wrote:
> Hi Shubham,
>
> On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal <
> [email protected]> wrote:
>
>> Hi Team,
>>
>> I have modified following two functions in pgadmin_page.py :-
>>
>> 1. click_tab() -> Added wait till element is clickable, test cases are
>> failing since the function attempts to click the tab which is not yet in
>> the state to be clicked.
>>
>> 2. add_server() -> Replaced the sleep statement with wait till element to
>> be clickable.
>>
>> Please find the attached patch.
>>
>> We should start using CSS selectors instead of xpath, otherwise the patch
> works fine and also changes look good to me.
>
>> --
>> Thanks & Regards,
>> Shubham Agarwal
>> EnterpriseDB Corporation
>>
>> The Postgres Database Company
>>
>
>
--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation
The Postgres Database Company
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgadmin_page functions updated
In-Reply-To: <CAKbCA9Q2Dyr7UAt6b6trk-7C2_088G2nBKznOh2gZVB2CndPSQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox