public inbox for [email protected]
help / color / mirror / Atom feedFrom: Sahil Harpal <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Cc: [email protected]
Cc: Dave Page <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Subject: Re: Pgadmin4 System Stats Extension Design
Date: Fri, 25 Aug 2023 13:41:33 +0530
Message-ID: <CAKi=nnfhOd4+zFYCZgnmeXqX5_TjW12qU6MGgV0EuFGUDNAmRQ@mail.gmail.com> (raw)
In-Reply-To: <CAKi=nndiSd72JfW+2npo6r4Q_7csoK-UT37EErVAY0vi2BziJQ@mail.gmail.com>
References: <CAKi=nnc6Ze8QWBmSHe9YBYciWeDzMf=-rw9BgyNocFSokrpi6w@mail.gmail.com>
<CAKi=nneuTPLMppZaAm-Y1X=4mY3UnbkbJAMCHF=Fu-2+kateRg@mail.gmail.com>
<CAFOhELdhcYr9NBNrkEAWt_cwP77U2ANRK4xonqKA1p6WpMBdMA@mail.gmail.com>
<CAKi=nnfSoagHGwa4To7ND39Sb0qcUVBsL2HZB0X4d_4qAus2Nw@mail.gmail.com>
<CAKi=nndD92uV-RifeDJqs_3YV+ABWiN1_iMLUi7Zf1AaHzwM0w@mail.gmail.com>
<CAFOhELeVGiCarA9-AK_Wi9EpNxKrF4Ev7VNNQCD=LZy9OM0aqg@mail.gmail.com>
<CAKi=nncs=LaytGKL8muxfP--nXjdW4P+cdZW=RRprd4UZ3mMZQ@mail.gmail.com>
<CAKi=nncpnEObc29MmGBAq58QKuFAdXrV7EDtf4Sp0QBuHV0Z4Q@mail.gmail.com>
<CAFOhELeBxSfF8PUk556R-cBoyvNrLkU3NDWhzbFbD1OQfp+xwA@mail.gmail.com>
<CAKi=nnfY22PmFOfGsyN1-piwicLDDrs8v8ACkzzQVXdywzNVQQ@mail.gmail.com>
<CAM9w-_m_zj456pHLQ0vkthgoxfbkd_C8ywguYdTFdG4W2+Znnw@mail.gmail.com>
<CAKi=nnfrnbsiGaSVNPq-+wUcLiihhBEvjGjY5JMaFiw6KmGOgw@mail.gmail.com>
<CAM9w-_=Mz0gT0SZyfLa+5Gjq9WHKtiDDvKfJcQhkDE1dC7HcyA@mail.gmail.com>
<CAKi=nnesjQ_z58hrzjw7pjCTp95N67O5Jyq4uqAcYhTJwCUHGw@mail.gmail.com>
<CAM9w-_ki8J4F5p3ioKFaa4Qq6OKykbFnJ=0xnSispVaRyec1yA@mail.gmail.com>
<CAKi=nndiSd72JfW+2npo6r4Q_7csoK-UT37EErVAY0vi2BziJQ@mail.gmail.com>
I have added the idea of array initialization for the 'Process & handle
count' chart. Let me know if similar can be used for all the streaming
charts to resolve the graph shifting issue.
On Fri, 25 Aug 2023 at 13:34, Sahil Harpal <[email protected]>
wrote:
> Hi Aditya,
> On Fri, 25 Aug 2023 at 12:32, Aditya Toshniwal <
> [email protected]> wrote:
>
>>
>> On Fri, Aug 25, 2023 at 12:15 PM Sahil Harpal <[email protected]>
>> wrote:
>>
>>> Hi Aditya,
>>>
>>> On Fri, 25 Aug 2023 at 12:06, Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Sahil,
>>>>
>>>> On Fri, Aug 25, 2023 at 12:02 PM Sahil Harpal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Aditya,
>>>>> On Fri, 25 Aug 2023 at 11:29, Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>> [image: image.gif]
>>>>>
>>>>>> Hi Sahil,
>>>>>> On Thu, Aug 24, 2023 at 8:07 PM Sahil Harpal <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>> Can we include total space stats (left pie chart) in the same bar
>>>>>>> chart? or would it be better if we keep it separate?
>>>>>>> [image: image.png]
>>>>>>>
>>>>>> How do you propose to merge both? I would also suggest using a
>>>>>> stacked bar chart on the right. And format from bytes to MBs.
>>>>>>
>>>>>>> [image: image.gif]
>>>>>>>
>>>>>>
>>>>> Currently, I have implemented like this:
>>>>> [image: image.png]
>>>>> So, I was thinking of adding one more column for total space for each
>>>>> disk.
>>>>> Regarding the stacked bar chart, we will need to increase the height
>>>>> of the default chart container; otherwise, the proportion of different
>>>>> categories won't be clearly visible in some cases.
>>>>> And I believe that if we use a stacked bar chart, there won't be a
>>>>> need to provide total space details, as the height of that stacked bar will
>>>>> be nothing but the total space, right?
>>>>>
>>>> I don't think we'll need to increase the height though. Even if you use
>>>> stacks, they will show total for each drive and not total available space.
>>>>
>>>
>>> Ahh yes, users won't be able to see the absolute total value. So should
>>> I change it to a stacked bar with 3 categories then?
>>>
>> I would suggest keeping the pie chart and making the stacks of used and
>> unused. If possible please keep the pie chart colors different from bar
>> chart.
>>
> Ok, sure I'll do it.
>
> On Fri, 25 Aug 2023 at 11:56, Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Sahil,
>> Can you please share the rebased patch?
>>
> Please find the attached patch with recent changes. It doesn't include
> this stacked bar, but it contains things suggested in the second review,
> and I also tried to resolve the tooltip issue. Let me know if it's working
> correctly.
> I have also pushed these changes here:
> https://github.com/Sahil1479/pgadmin4/tree/system_stats [Branch:
> system_stats]
>
> I will share the final patch with a detailed summary of all the things
> that have been changed once I complete this stacked/pie chart and a few
> more refinements.
>
> Thank you,
> Sahil
>
Attachments:
[image/png] image.png (44.9K, 3-image.png)
download | view image
[image/png] image.png (13.6K, 4-image.png)
download | view image
[image/gif] image.gif (42B, 5-image.gif)
download | view image
[image/gif] image.gif (42B, 6-image.gif)
download | view image
view thread (106+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Pgadmin4 System Stats Extension Design
In-Reply-To: <CAKi=nnfhOd4+zFYCZgnmeXqX5_TjW12qU6MGgV0EuFGUDNAmRQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox