public inbox for [email protected]
help / color / mirror / Atom feedFrom: Priyanka Shendge <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Kanchan Mohitey <[email protected]>
Subject: Re: pgAdmin IV API test cases patch
Date: Thu, 23 Jun 2016 19:11:55 +0530
Message-ID: <CAKmZXFRWXd7ZrUhpJt-rD_YOE1xcK5haE1CwAj8DMVyS9Fs6yA@mail.gmail.com> (raw)
In-Reply-To: <CAKmZXFSgdtd9NDE=TysR68_tcwqFB2Sv-h+qK4K4i1HjxOd5ng@mail.gmail.com>
References: <CAKmZXFQ2Hj1-OZpSGFEBB-vOypQ_=1b4Yr_VytZ-E1=CBw9Yhw@mail.gmail.com>
<CA+OCxow8Q83e7Tm+BC2bxq=oqwd-m4JS3y2KpzgFemc=wX=f=A@mail.gmail.com>
<CAKmZXFTX9D_qOXGrvPa9sfFjc1A6VPebcpBn7vyzPEOH4pWfEg@mail.gmail.com>
<CAKmZXFRj8yY91TTxwQQ01eOQE8Rc7FPWuxGcjxaVY+QcWpgWDg@mail.gmail.com>
<CA+OCxoyqfK8pUGGmeO=5pyC=MOizNMOnfshAfgQ5NjMRnkjgmA@mail.gmail.com>
<CAKmZXFSgdtd9NDE=TysR68_tcwqFB2Sv-h+qK4K4i1HjxOd5ng@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On 15 June 2016 at 15:05, Priyanka Shendge <
[email protected]> wrote:
> Thanks a lot Dave.
>
> On 15 June 2016 at 14:09, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge
>> <[email protected]> wrote:
>> > Hi Dave,
>> >
>> > PFA updated patch. I have made changes suggested by you.
>> >
>> > Kindly, review and let me know for more changes.
>>
>> OK, I got a bit further this time, but not there yet.
>>
>> 1) The patch overwrote my test_config.json file. That should never
>> happen (that file shouldn't be in the source tree).
>> test_config.json.in should be the file that's included in the patch.
>>
>
> OK.
>
>>
>> 2) The updated test_config.json file is huge.
>
>
Current configuration file web/regression/test_config.json contains test
data(credentials) for each tree node;
which is used while adding and updating the respective node.
> I should only need to
>> define one or more connections, then be able to run the tests. If you
>> need to keep configuration info for "advanced users", let's put it in
>> a different file to avoid confusing/scaring everyone else. Maybe split
>> it into config.json for the stuff the user needs to edit
>> (config.json.in would go in git), and test_config.json for the test
>> configuration.
>
>
Should i keep login and server credentials into
web/regression/test_config.json file and
put respective node details into config.json file of respective node's
tests directory?
e.g. for database node:
I'll create config.json file into .../databases/tests/ directory
put database add and update credentials into config.json
>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Best,
> Priyanka
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
--
Best,
Priyanka
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
view thread (27+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgAdmin IV API test cases patch
In-Reply-To: <CAKmZXFRWXd7ZrUhpJt-rD_YOE1xcK5haE1CwAj8DMVyS9Fs6yA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox