public inbox for [email protected]
help / color / mirror / Atom feed[RM3645] Start and End Date does not delete for Schedules in pgAgent Job
7+ messages / 3 participants
[nested] [flat]
* [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
@ 2020-03-30 12:27 Rahul Shirsat <[email protected]>
2020-03-31 05:54 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Akshay Joshi <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Rahul Shirsat @ 2020-03-30 12:27 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find the patch for pgagents schedules dates issue.
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM3645.patch (897B, 3-RM3645.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index b05e1422f..cb45c2d6e 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -1804,15 +1804,11 @@ define([
this.$el.datetimepicker('destroy');
this.is_closing = false;
- if (_.isUndefined(newValue)) {
- model.trigger('backgrid:error', model, column, val);
- } else {
- model.set(column.get('name'), newValue);
- let command = new Backgrid.Command(ev);
- setTimeout(() => {
- model.trigger('backgrid:edited', model, column, command);
- }, 20);
- }
+ model.set(column.get('name'), newValue);
+ let command = new Backgrid.Command(ev);
+ setTimeout(() => {
+ model.trigger('backgrid:edited', model, column, command);
+ }, 20);
},
});
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
2020-03-30 12:27 [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
@ 2020-03-31 05:54 ` Akshay Joshi <[email protected]>
2020-03-31 06:17 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Akshay Joshi @ 2020-03-31 05:54 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers; Rahul Shirsat <[email protected]>
Hi Aditya
Can you please review it.
On Mon, Mar 30, 2020 at 5:57 PM Rahul Shirsat <
[email protected]> wrote:
> Hi Hackers,
>
> Please find the patch for pgagents schedules dates issue.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
2020-03-30 12:27 [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
2020-03-31 05:54 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Akshay Joshi <[email protected]>
@ 2020-03-31 06:17 ` Aditya Toshniwal <[email protected]>
2020-03-31 08:44 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Aditya Toshniwal @ 2020-03-31 06:17 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers; Rahul Shirsat <[email protected]>
Hi Rahul,
The patch looks good to me. But can you please remove the placeholder in
the properties tab. It looks like some value is set, but I kept it empty.
Refer below screenshot:
[image: image.png]
On Tue, Mar 31, 2020 at 11:24 AM Akshay Joshi <[email protected]>
wrote:
> Hi Aditya
>
> Can you please review it.
>
> On Mon, Mar 30, 2020 at 5:57 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find the patch for pgagents schedules dates issue.
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachments:
[image/png] image.png (138.6K, 3-image.png)
download | view image
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
2020-03-30 12:27 [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
2020-03-31 05:54 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Akshay Joshi <[email protected]>
2020-03-31 06:17 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Aditya Toshniwal <[email protected]>
@ 2020-03-31 08:44 ` Rahul Shirsat <[email protected]>
2020-03-31 08:45 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Rahul Shirsat @ 2020-03-31 08:44 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: Akshay Joshi <[email protected]>; pgadmin-hackers
Thanks Aditya for reviewing.
I have made the relevant changes, please find the inclusive patch attached
here.
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
On Tue, Mar 31, 2020 at 11:48 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Rahul,
>
> The patch looks good to me. But can you please remove the placeholder in
> the properties tab. It looks like some value is set, but I kept it empty.
> Refer below screenshot:
>
> [image: image.png]
>
> On Tue, Mar 31, 2020 at 11:24 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Aditya
>>
>> Can you please review it.
>>
>> On Mon, Mar 30, 2020 at 5:57 PM Rahul Shirsat <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the patch for pgagents schedules dates issue.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Attachments:
[image/png] image.png (138.6K, 3-image.png)
download | view image
[application/octet-stream] RM3645.patch (1.4K, 4-RM3645.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index a57f70ebc..ec491096e 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -2977,7 +2977,7 @@ define([
data.cId = data.cId || _.uniqueId('pgC_');
- if (!data.disabled) {
+ if (!data.disabled && data.mode != 'properties') {
data.placeholder = data.placeholder || this.defaults.placeholder;
}
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index b05e1422f..cb45c2d6e 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -1804,15 +1804,11 @@ define([
this.$el.datetimepicker('destroy');
this.is_closing = false;
- if (_.isUndefined(newValue)) {
- model.trigger('backgrid:error', model, column, val);
- } else {
- model.set(column.get('name'), newValue);
- let command = new Backgrid.Command(ev);
- setTimeout(() => {
- model.trigger('backgrid:edited', model, column, command);
- }, 20);
- }
+ model.set(column.get('name'), newValue);
+ let command = new Backgrid.Command(ev);
+ setTimeout(() => {
+ model.trigger('backgrid:edited', model, column, command);
+ }, 20);
},
});
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
2020-03-30 12:27 [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
2020-03-31 05:54 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Akshay Joshi <[email protected]>
2020-03-31 06:17 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Aditya Toshniwal <[email protected]>
2020-03-31 08:44 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
@ 2020-03-31 08:45 ` Rahul Shirsat <[email protected]>
2020-03-31 08:51 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Rahul Shirsat @ 2020-03-31 08:45 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: Akshay Joshi <[email protected]>; pgadmin-hackers
Hi,
Ignore the previous mail, find the latest patch attached.
On Tue, Mar 31, 2020 at 2:14 PM Rahul Shirsat <
[email protected]> wrote:
> Thanks Aditya for reviewing.
>
> I have made the relevant changes, please find the inclusive patch attached
> here.
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
> On Tue, Mar 31, 2020 at 11:48 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Rahul,
>>
>> The patch looks good to me. But can you please remove the placeholder in
>> the properties tab. It looks like some value is set, but I kept it empty.
>> Refer below screenshot:
>>
>> [image: image.png]
>>
>> On Tue, Mar 31, 2020 at 11:24 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Aditya
>>>
>>> Can you please review it.
>>>
>>> On Mon, Mar 30, 2020 at 5:57 PM Rahul Shirsat <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the patch for pgagents schedules dates issue.
>>>>
>>>> --
>>>> *Rahul Shirsat*
>>>> Software Engineer | EnterpriseDB Corporation.
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Attachments:
[image/png] image.png (138.6K, 3-image.png)
download | view image
[application/octet-stream] RM3645_v2.patch (1.4K, 4-RM3645_v2.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index a57f70ebc..ec491096e 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -2977,7 +2977,7 @@ define([
data.cId = data.cId || _.uniqueId('pgC_');
- if (!data.disabled) {
+ if (!data.disabled && data.mode != 'properties') {
data.placeholder = data.placeholder || this.defaults.placeholder;
}
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index b05e1422f..cb45c2d6e 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -1804,15 +1804,11 @@ define([
this.$el.datetimepicker('destroy');
this.is_closing = false;
- if (_.isUndefined(newValue)) {
- model.trigger('backgrid:error', model, column, val);
- } else {
- model.set(column.get('name'), newValue);
- let command = new Backgrid.Command(ev);
- setTimeout(() => {
- model.trigger('backgrid:edited', model, column, command);
- }, 20);
- }
+ model.set(column.get('name'), newValue);
+ let command = new Backgrid.Command(ev);
+ setTimeout(() => {
+ model.trigger('backgrid:edited', model, column, command);
+ }, 20);
},
});
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
2020-03-30 12:27 [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
2020-03-31 05:54 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Akshay Joshi <[email protected]>
2020-03-31 06:17 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Aditya Toshniwal <[email protected]>
2020-03-31 08:44 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
2020-03-31 08:45 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
@ 2020-03-31 08:51 ` Aditya Toshniwal <[email protected]>
2020-04-01 09:50 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Akshay Joshi <[email protected]>
0 siblings, 1 reply; 7+ messages in thread
From: Aditya Toshniwal @ 2020-03-31 08:51 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: Akshay Joshi <[email protected]>; pgadmin-hackers
Hi Rahul,
The patch looks good to me. It can be committed.
On Tue, Mar 31, 2020 at 2:15 PM Rahul Shirsat <
[email protected]> wrote:
> Hi,
>
> Ignore the previous mail, find the latest patch attached.
>
> On Tue, Mar 31, 2020 at 2:14 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Thanks Aditya for reviewing.
>>
>> I have made the relevant changes, please find the inclusive patch
>> attached here.
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>> On Tue, Mar 31, 2020 at 11:48 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Rahul,
>>>
>>> The patch looks good to me. But can you please remove the placeholder in
>>> the properties tab. It looks like some value is set, but I kept it empty.
>>> Refer below screenshot:
>>>
>>> [image: image.png]
>>>
>>> On Tue, Mar 31, 2020 at 11:24 AM Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Hi Aditya
>>>>
>>>> Can you please review it.
>>>>
>>>> On Mon, Mar 30, 2020 at 5:57 PM Rahul Shirsat <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please find the patch for pgagents schedules dates issue.
>>>>>
>>>>> --
>>>>> *Rahul Shirsat*
>>>>> Software Engineer | EnterpriseDB Corporation.
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect*
>>>> *EnterpriseDB Software India Private Limited*
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachments:
[image/png] image.png (138.6K, 3-image.png)
download | view image
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
2020-03-30 12:27 [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
2020-03-31 05:54 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Akshay Joshi <[email protected]>
2020-03-31 06:17 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Aditya Toshniwal <[email protected]>
2020-03-31 08:44 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
2020-03-31 08:45 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
2020-03-31 08:51 ` Re: [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Aditya Toshniwal <[email protected]>
@ 2020-04-01 09:50 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: Akshay Joshi @ 2020-04-01 09:50 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: Rahul Shirsat <[email protected]>; pgadmin-hackers
Thanks, patch applied.
On Tue, Mar 31, 2020 at 2:21 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Rahul,
>
> The patch looks good to me. It can be committed.
>
> On Tue, Mar 31, 2020 at 2:15 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Hi,
>>
>> Ignore the previous mail, find the latest patch attached.
>>
>> On Tue, Mar 31, 2020 at 2:14 PM Rahul Shirsat <
>> [email protected]> wrote:
>>
>>> Thanks Aditya for reviewing.
>>>
>>> I have made the relevant changes, please find the inclusive patch
>>> attached here.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>> On Tue, Mar 31, 2020 at 11:48 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Rahul,
>>>>
>>>> The patch looks good to me. But can you please remove the placeholder
>>>> in the properties tab. It looks like some value is set, but I kept it
>>>> empty. Refer below screenshot:
>>>>
>>>> [image: image.png]
>>>>
>>>> On Tue, Mar 31, 2020 at 11:24 AM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Aditya
>>>>>
>>>>> Can you please review it.
>>>>>
>>>>> On Mon, Mar 30, 2020 at 5:57 PM Rahul Shirsat <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Please find the patch for pgagents schedules dates issue.
>>>>>>
>>>>>> --
>>>>>> *Rahul Shirsat*
>>>>>> Software Engineer | EnterpriseDB Corporation.
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect*
>>>>> *EnterpriseDB Software India Private Limited*
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
Attachments:
[image/png] image.png (138.6K, 3-image.png)
download | view image
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2020-04-01 09:50 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 12:27 [RM3645] Start and End Date does not delete for Schedules in pgAgent Job Rahul Shirsat <[email protected]>
2020-03-31 05:54 ` Akshay Joshi <[email protected]>
2020-03-31 06:17 ` Aditya Toshniwal <[email protected]>
2020-03-31 08:44 ` Rahul Shirsat <[email protected]>
2020-03-31 08:45 ` Rahul Shirsat <[email protected]>
2020-03-31 08:51 ` Aditya Toshniwal <[email protected]>
2020-04-01 09:50 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox