public inbox for [email protected]  

help / color / mirror / Atom feed

From: Rahul Shirsat <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin] RM6084 Uncaught TypeError exception displayed on schema diff identical option
Date: Thu, 17 Dec 2020 19:07:25 +0530
Message-ID: <CAKtn9dOhhQRniOZ1Wtd6bfapp+yxsy1Kxc+u=b_fdAAQRdJEWw@mail.gmail.com> (raw)

Hi Hackers,

Please find the attached patch which resolves 2 issues:

   1. When the user applies the "Identical" filter before hitting the
   Compare button. (All Browsers)
   2. When comparing data is loaded, and when the user selects identical
   table comparison, infinite loader "Comparing objects..." shows up in
   Firefox.

-- 
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.


Attachments:

  [application/octet-stream] RM6084.patch (1.1K, 3-RM6084.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js b/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
index 1f499e5cd..6738a64b4 100644
--- a/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
+++ b/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
@@ -456,7 +456,9 @@ export default class SchemaDiffUI {
 
     grid.onSelectedRowsChanged.subscribe(self.handleDependencies.bind(this));
 
-    self.model.on('change:diff_ddl', self.handleDependencies.bind(self));
+    self.model.on('change:diff_ddl', function(event) {
+      self.handleDependencies.bind(event, self);
+    });
 
     $('#schema-diff-grid').on('keyup', function() {
       if ((event.keyCode == 38 || event.keyCode ==40) && this.grid.getActiveCell().row) {
@@ -831,8 +833,12 @@ export default class SchemaDiffUI {
         }
       }
     });
-    // Refresh the grid
-    self.dataView.refresh();
+
+    // Check whether comparison data is loaded or not
+    if(!_.isUndefined(self.dataView) && !_.isNull(self.dataView)) {
+      // Refresh the grid
+      self.dataView.refresh();
+    }
   }
 
   connect_database(server_id, db_id, callback) {

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin] RM6084 Uncaught TypeError exception displayed on schema diff identical option
  In-Reply-To: <CAKtn9dOhhQRniOZ1Wtd6bfapp+yxsy1Kxc+u=b_fdAAQRdJEWw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox