public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin] RM4847 & RM4849 Double % & Relation name issue Explain -> Statistics
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin] RM4847 & RM4849 Double % & Relation name issue Explain -> Statistics
@ 2021-03-11 11:43 Rahul Shirsat <[email protected]>
2021-03-12 06:11 ` Re: [pgAdmin] RM4847 & RM4849 Double % & Relation name issue Explain -> Statistics Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Shirsat @ 2021-03-11 11:43 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find below patch which resolves:
RM4847 <https://redmine.postgresql.org/issues/4847; : If user select timing
under explain analyze the % displayed twice for query and table
RM4849 <https://redmine.postgresql.org/issues/4849; : Statistic per view
and materialized view should display for Explain Analyze
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
Attachments:
[application/octet-stream] RM4849_RM4847.patch (2.0K, 3-RM4849_RM4847.patch)
download | inline diff:
diff --git a/web/pgadmin/misc/static/explain/js/explain.js b/web/pgadmin/misc/static/explain/js/explain.js
index 00e7a0ff6..e5dd542d9 100644
--- a/web/pgadmin/misc/static/explain/js/explain.js
+++ b/web/pgadmin/misc/static/explain/js/explain.js
@@ -206,27 +206,27 @@ define('pgadmin.misc.explain', [
' <th class="renderable timings d-none"><button disabled>',
gettext('Time spent') ,'</button></th>',
' <th class="renderable timings d-none"><button disabled>',
- gettext('%% of query') ,'</button></th>',
+ '% ', gettext('of query') ,'</button></th>',
' </tr>',
' </thead>',
' </table>',
' </div>',
' <div class="col-sm-6 col-xs-6">',
' <div class="col-xs-12 badge">',
- gettext('Statistics per Table'),
+ gettext('Statistics per Relation'),
' </div>',
' <table class="backgrid table presentation table-bordered ',
' table-hover" for="per_table">',
' <thead>',
' <tr>',
' <th class="renderable"><button disabled>',
- gettext('Table name') , '</button></th>',
+ gettext('Relation name') , '</button></th>',
' <th class="renderable"><button disabled>',
gettext('Scan count'), '</button></th>',
' <th class="renderable timings d-none"><button disabled>',
gettext('Total time') ,'</button></th>',
' <th class="renderable timings d-none"><button disabled>',
- gettext('%% of query') ,'</button></th>',
+ '% ', gettext('of query') ,'</button></th>',
' </tr>',
' <tr>',
' <th class="renderable"><button disabled>',
@@ -236,7 +236,7 @@ define('pgadmin.misc.explain', [
' <th class="renderable timings d-none"><button disabled>',
gettext('Sum of times') ,'</button></th>',
' <th class="renderable timings d-none"><button disabled>',
- gettext('%% of table') ,'</button></th>',
+ '% ', gettext('of relation') ,'</button></th>',
' </tr>',
' </thead>',
' </table>',
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin] RM4847 & RM4849 Double % & Relation name issue Explain -> Statistics
2021-03-11 11:43 [pgAdmin] RM4847 & RM4849 Double % & Relation name issue Explain -> Statistics Rahul Shirsat <[email protected]>
@ 2021-03-12 06:11 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2021-03-12 06:11 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Thu, Mar 11, 2021 at 5:13 PM Rahul Shirsat <
[email protected]> wrote:
> Hi Hackers,
>
> Please find below patch which resolves:
>
> RM4847 <https://redmine.postgresql.org/issues/4847; : If user select
> timing under explain analyze the % displayed twice for query and table
>
> RM4849 <https://redmine.postgresql.org/issues/4849; : Statistic per view
> and materialized view should display for Explain Analyze
>
>
> --
> *Rahul Shirsat*
> Senior Software Engineer | EnterpriseDB Corporation.
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-03-12 06:11 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-11 11:43 [pgAdmin] RM4847 & RM4849 Double % & Relation name issue Explain -> Statistics Rahul Shirsat <[email protected]>
2021-03-12 06:11 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox