public inbox for [email protected]  

help / color / mirror / Atom feed
From: Surinder Kumar <[email protected]>
To: Dave Page <[email protected]>
Cc: Marc Linster <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error
Date: Tue, 12 Jul 2016 11:40:07 +0530
Message-ID: <CAM5-9D-ZHXrQgYrTg5FOLNX+xSxR0gaGBmv4SK7Scqb4djhgUw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoxCvvO6WSvqiJ9zgbynAYXyybtd=kkOCLMBPKU-0POBgQ@mail.gmail.com>
References: <CAM5-9D_ebJh8VJfvhk2cR-w=QqkC2YTWhc8ft+v3a9qSTTotKw@mail.gmail.com>
	<CA+OCxoxNCNF9bgzJH7+-04o3-agSX8-Py4OgaKvfjfUt0vLi=w@mail.gmail.com>
	<CAM5-9D-MdMz=s4pLdf9E9P_pXfF4Dh49pzq3wbJjO3xV-h9WyQ@mail.gmail.com>
	<CAM5-9D_eeVg_=hPPTybEp2Traoqdj9jEnwTTAaJQQ-M5LiEo=A@mail.gmail.com>
	<CA+OCxoxCvvO6WSvqiJ9zgbynAYXyybtd=kkOCLMBPKU-0POBgQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

On Mon, Jul 11, 2016 at 6:41 PM, Dave Page <[email protected]> wrote:

> On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar
> <[email protected]> wrote:
> > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar
> > <[email protected]> wrote:
> >>
> >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page <[email protected]> wrote:
> >>>
> >>> Hi,
> >>>
> >>> I think we need more changes than just that;
> >>>
> >>> - The path at the top should not be editable (it should be greyed in
> >>> fact)
> >>
> >> Ok
> >>>
> >>>
> >>> - The path at the top should only show the directory path. The
> >>> filename should never be appended.
> >>
> >> Ok
> >>>
> >>>
> >>> - The CSS needs to be fixed so the filename textbox at the bottom is
> >>> never hidden (as it is now if the dialogue opens at a small size).
> >>
> >> Ok
> >>>
> >>>
> >>> - Double-click to navigate vs. rename should be modified to work in
> >>> part like it does on Mac - Double-click on either the icon or the name
> >>> should open the item (browser into a folder, or select and "OK" on a
> >>> file), and Click then Enter should rename. I'm hesitant to try to
> >>> implement "slow double click to rename" as that would likely need to
> >>> be tunable for accessibility reasons.
> >>
> >> Ok, I will fix it.
> >
> > In the current scenario, the Enter Key is bound to the OK button by
> default
> > in Alertify dialog which servers the purpose of closing the dialog.
> > Should we de-attach Enter Key event bound to OK button and use it for
> rename
> > file?
> > please suggest what should I do?
>
> Hmm, good point.
>
> How hard would it be to look for 2 consecutive single-clicks (but not
> a double-click) for rename? If we can do that, it avoids timing
> considerations for double-clicks (which would be defined by the OS).
>

I tried to implement slow double click, here is Fiddle
<https://jsfiddle.net/5kwn6mj2/#;
There are two events 1) double click (it will be used for folder navigation)
2) Slow double click(For rename), It is a simple click event, when clicked
twice after delay we consider it a slow double click.

But it is not working smoothly, double click and single click events are
conflicting.

Also, we have rename button in navigation for rename operation,
Can we skip slow double click because it is very confusing?

>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


view thread (12+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error
  In-Reply-To: <CAM5-9D-ZHXrQgYrTg5FOLNX+xSxR0gaGBmv4SK7Scqb4djhgUw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox