public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [Patch][pgAdmin4]: RM1519 - Error running VACUUM FULL FREEZE ANALYZE VERBOSE
Date: Thu, 4 Aug 2016 15:29:28 +0530
Message-ID: <CAM5-9D8_CDrMGu_m1ZRsceHRHgK=W_ea-tueMSZFo7Be-FD-pg@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

This issue is reproduced to me with following steps.:
1) When the query "VACUUM FULL FREEZE ANALYZE VERBOSE" is run for first
time, it runs without error.
2) then the query "SELECT 1" is executed. no error.
3) But when query in step #1 is run again, it throws an error:
*TypeError: cannot concatenate 'str' and 'NoneType' objects*

4) Now executing query in step #2 throws following error:
*Error Message:execute cannot be used while an asynchronous query is
underway********** Error ***********

*Reason:*
When the query in step #1 is run for second time as in step #3, it fails
due to python error thus loading spinner stops and run query button is
enabled. but the query is still running in background.

then on running query in step #4 throws error with message "asynchronous
query is underway" because last run query is not yet finished.

*Solution:*
This is due to python error.
String type and NoneType is now formatted properly which resolves the issue.

Please find attached patch and review.


Thanks,
Surinder Kumar


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] RM1519.patch (569B, 3-RM1519.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py
index 0c3e38d..bb5c26b 100644
--- a/web/pgadmin/tools/sqleditor/__init__.py
+++ b/web/pgadmin/tools/sqleditor/__init__.py
@@ -461,7 +461,7 @@ def poll(trans_id):
             """
             if isinstance(additional_result, list) \
                     and len(additional_result) > 0:
-                result = str(additional_result[-1]) + result
+                result = "{0} {1}".format(additional_result[-1], result)

             rows_affected = conn.rows_affected()

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [Patch][pgAdmin4]: RM1519 - Error running VACUUM FULL FREEZE ANALYZE VERBOSE
  In-Reply-To: <CAM5-9D8_CDrMGu_m1ZRsceHRHgK=W_ea-tueMSZFo7Be-FD-pg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox