public inbox for [email protected]
help / color / mirror / Atom feedFrom: Surinder Kumar <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4] [Patch]: Grant Wizard
Date: Wed, 11 May 2016 22:58:43 +0530
Message-ID: <CAM5-9D9PgDyCfg=B6MS=hPh0ZPBS+jtgcBLh6PCSyuhmrCv7pQ@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D8p6_Vht-Fd-3xq_Fxc4TgJ_4aqzYaArbgNJsa34e4Lww@mail.gmail.com>
References: <CAM5-9D8oYyEaL89coD9FozPDziGhYutYAat9dMP9dAwhOp5OKQ@mail.gmail.com>
<CA+OCxozy4aH9=2T0Sp_WworU_3UQaaHBcQXTDhEUKHAkZJT8ow@mail.gmail.com>
<CA+OCxoyGKAorswp0fwUojT4gB0Ex+dcRxzKbLkfG48qeCmSCrQ@mail.gmail.com>
<CAM5-9D_D3TGq9-DbcR+07=p2cgT=yEtmEJnHU9rtmov_nby9+g@mail.gmail.com>
<CAM5-9D_6kD3yEcZ3A4A6WOT7aRk_EGru6LSswQv+PBmK=2QKfA@mail.gmail.com>
<CA+OCxozwOV+FixF3-9KgmGOaytZQ3Fsn3_BNAyCNqQPtLp+_VQ@mail.gmail.com>
<CAM5-9D9vGUgGaACFZc1YxFNp_gi-fAm=w2rf_JmNtD+HBi64=w@mail.gmail.com>
<CA+OCxozvNDNi0MBVQ3Gq7GhT27o2MX2=KuFUE+pUUqOCbufe+A@mail.gmail.com>
<CAM5-9D8ZHTvx53WhL2S0XUt8o+LE0aiCxMLQJGP2PUg_Q4S1dw@mail.gmail.com>
<CAM5-9D-bSJx-u_K+o2eQhd8r_39+CTxmabg9wkXP_NzVu9Eo2A@mail.gmail.com>
<CA+OCxozp8ZS5wHLAFuONT9Ap93De6so2Eg=ta028eusQwt=fEA@mail.gmail.com>
<CAM5-9D9Z9-x9Bbb0rFFS34xCy_GNsdot2bQ4rbYMPq=pWL3Vew@mail.gmail.com>
<CAM5-9D9hQZWsYETszCV7=dVsLf6KHojC9P+_icmHFGCh8jFHnQ@mail.gmail.com>
<CAG7mmowJONpMzMva7qxLQ=Wd5bFxXMsV7URosk8O5zVKLPXwnA@mail.gmail.com>
<CAM5-9D9R4vR6TfOLd+NiSVWZy+L0Z+8Jj=A-v-tP5f_5Of5ksA@mail.gmail.com>
<CA+OCxownatDkVQsZGKJUwO1=co0XOf0J=U5ydSYh8=xXi7ogTQ@mail.gmail.com>
<CAM5-9D-ixhoFahG2dxmZCxhv_VVm0ncsqm075kemZ+M7kuoKPw@mail.gmail.com>
<CA+OCxoyC-U+u8eESm8NXchX+s9dwdCFKMJ3x5JcZNCAgN4CnPw@mail.gmail.com>
<CAM5-9D_TmnFfVEw1OXTL-f4jgtCiE+e2rQuSKa4yqPX7ZsSBNg@mail.gmail.com>
<CA+OCxoy_DPvhJfViwsmKSBgwxBx51g=W6qu+NuqED_yTDm2gCw@mail.gmail.com>
<CAM5-9D_29dfZZ8wG8wWQz41H3UTMUhRX5YU4X7Nehyh3bsMh2A@mail.gmail.com>
<CAM5-9D8p6_Vht-Fd-3xq_Fxc4TgJ_4aqzYaArbgNJsa34e4Lww@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi,
PFA updated patch
*Change*: removed '*ajs_content*' css from *wizard.css* causing padding
issue in alertify dialog.
Thanks murtuza for reporting.
On Fri, May 6, 2016 at 3:00 PM, Surinder Kumar <
[email protected]> wrote:
> Hi,
>
> PFA patch with following issues fixed:
> 1. As SqlTab Control is renamed to SqlCtrl, throws error on grant wizard
> close. it is Fixed.
> 2. Moved grant wizard specific css from wizard.css to grant_wizard.css.
>
> On Wed, Apr 13, 2016 at 8:41 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Fri, Apr 8, 2016 at 6:59 PM, Surinder Kumar <
>> [email protected]> wrote:
>>
>>> Hi
>>>
>>> PFA patch with resolved review comments.
>>>
>>> On Fri, Apr 8, 2016 at 12:52 AM, Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> Nearly there :-). Assuming no regressions, I believe we'll be ready to
>>>> commit once the following issues are resolved:
>>>>
>>>> - The select object grid should fill the available vertical space in
>>>> the dialogue - at present there's a gap below it.
>>>>
>>> Done
>>>
>>
>> This does not seem to be fixed (see attached screenshot). In fact, the
>> gap gets bigger proportionally as the window is resized.
>>
> Fixed
>
>>
>>
>>>
>>>> - When selecting privileges, each time I click on a checkbox, the row
>>>> closes. Similar grids elsewhere in the app close the row when the cell
>>>> loses focus, *however*, that is also the incorrect behaviour - the row
>>>> should only close when the row itself loses focus (and should open when it
>>>> gets focus).
>>>>
>>> I checked the row closes either when gets clicked on row or outside row,
>>> it doesn't seems to close on click on checkbox.
>>>
>>
>> This is still broken for me. I'm using Chrome on OS X. As soon as I click
>> any checkbox, the row closes, and I have to click again to see the
>> checkboxes again.
>>
> I checked with Chrome on OS X, windows and ubuntu, it is working fine. Can
> you please send me screenshot if possible?
>
>>
>> One additional issue:
>>
>> - If I select some objects and permissions (in my case, everything in a
>> PEM database, and ALL), hit Next so I can see the SQL, then hit back
>> *twice*, I see the second attached screenshot.
>>
> I followed the same steps and when hit back twice on *previous* button of
> SQL page, it takes me to first page which is right.
> It would be easy for me to find out the exact cause if you send me output
> of browser console panel.
>
>>
>> I'm going to commit the code with these issues as they are largely
>> cosmetic. Please submit a patch to fix them (I'll add a new card to our
>> internal Kanban chart).
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] grant_wizard_v11.patch (1.0K, 3-grant_wizard_v11.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/static/css/wizard.css b/web/pgadmin/browser/static/css/wizard.css
index 2c19a09..da93d57 100644
--- a/web/pgadmin/browser/static/css/wizard.css
+++ b/web/pgadmin/browser/static/css/wizard.css
@@ -143,7 +143,3 @@
.select2-container--open {
z-index: 10000;
}
-
-.alertify .ajs-body .ajs-content {
- padding: 0px;
-}
\ No newline at end of file
diff --git a/web/pgadmin/tools/grant_wizard/templates/grant_wizard/js/grant_wizard.js b/web/pgadmin/tools/grant_wizard/templates/grant_wizard/js/grant_wizard.js
index 21f8516..aef7621 100644
--- a/web/pgadmin/tools/grant_wizard/templates/grant_wizard/js/grant_wizard.js
+++ b/web/pgadmin/tools/grant_wizard/templates/grant_wizard/js/grant_wizard.js
@@ -142,7 +142,7 @@ define([
var supported_nodes = [
'schema', 'coll-function', 'coll-sequence',
'coll-table', 'coll-view', 'coll-procedure',
- 'coll-materialized_view', 'database'
+ 'coll-mview', 'database'
],
/**
view thread (24+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin4] [Patch]: Grant Wizard
In-Reply-To: <CAM5-9D9PgDyCfg=B6MS=hPh0ZPBS+jtgcBLh6PCSyuhmrCv7pQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox