public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog
Date: Mon, 12 Sep 2016 11:51:06 +0530
Message-ID: <CAM5-9D9sQ0zee0Z4YpVEqKGzjf87-fa=sW1CpppcnVFhVXUO2Q@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZSTX3-tPKYtNw0VC8FtNRwmH7eXE8K6jDuyXjZM4FzonQ@mail.gmail.com>
References: <CAM5-9D8KtB8xSrL3z90CG_VEPm002oAPA-s3d3CHGR9p6Q3iMw@mail.gmail.com>
	<CAKKotZSTX3-tPKYtNw0VC8FtNRwmH7eXE8K6jDuyXjZM4FzonQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

On Mon, Sep 12, 2016 at 11:13 AM, Murtuza Zabuawala <murtuza.zabuawala@
enterprisedb.com> wrote:

> Hi Surinder,
>
> Just a heads up, When server is not connected and listed down in browser
> tree then node has attribute 'type' instead of 'server_type'.
> I have fixed similar issue few days ago Ref. link
> <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commit;h=013ff1090e4b084166077a9e43196a91d7e17e2...;
>
 Yup this was a
​bug
.
​ Previously, *server_type* was not returned​ on listing down after
disconnect then connect.
 And
​
it has already been taken care in this commit​
<https://www.postgresql.org/message-id/[email protected];
.
 So, the check will work fine with *server_type​. *

>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Sep 12, 2016 at 10:42 AM, Surinder Kumar <
> [email protected]> wrote:
>
>> Hi
>>
>> *Please find attached with following fixes:*
>>
>> 1) The function '*canCreateProc*' that checks if package is auth to
>> create under catalog gets failed due to improper check of 'type'. Instead
>> check should be like
>> node_hierarchy['server'].*server_type* == "ppas" not
>> node_hierarchy['server'].*type* == "ppas"
>>
>> 2) Also found, *package.js* was loading at schema level, due to this,
>> context menu doesn't popup under catalog. Now it is load at database level.
>>
>> 3) In *package.js*, remove extra comma from columns array.
>>
>> 4) Rule create option should not available on table under catalogs. Fixed.
>>
>> Please review.
>>
>> Thanks,
>> Surinder Kumar
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM1682 - create new Procedure option should not available on System catalog
  In-Reply-To: <CAM5-9D9sQ0zee0Z4YpVEqKGzjf87-fa=sW1CpppcnVFhVXUO2Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox