public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime
@ 2016-07-11 08:13 Surinder Kumar <[email protected]>
  2016-07-13 11:35 ` Re: [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime Dave Page <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Surinder Kumar @ 2016-07-11 08:13 UTC (permalink / raw)
  To: pgadmin-hackers

Hi

*Issue:*
When we click on "Clear query window" button in Query tool, a new instance
of query tool opens in new window. The event "StopEventPropogation" was not
working.

Please find the attached patch and review.

Thanks,
Surinder Kumar


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] clear_query_opens_in_new_window_mac_runtime.patch (657B, 3-clear_query_opens_in_new_window_mac_runtime.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 965d56e..233a6c4 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -862,9 +862,8 @@ define(

       // Callback function for the clear button click.
       on_clear: function(ev) {
-        ev = ev || window.event;
-        ev.cancelBubble = true;
-        ev.stopPropagation();
+        this._stopEventPropogation(ev);
+        this._closeDropDown(ev);

         this.query_tool_obj.setValue('');
       },


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime
  2016-07-11 08:13 [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime Surinder Kumar <[email protected]>
@ 2016-07-13 11:35 ` Dave Page <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2016-07-13 11:35 UTC (permalink / raw)
  To: Surinder Kumar <[email protected]>; +Cc: pgadmin-hackers

Thanks, applied.

On Mon, Jul 11, 2016 at 9:13 AM, Surinder Kumar
<[email protected]> wrote:
> Hi
>
> Issue:
> When we click on "Clear query window" button in Query tool, a new instance
> of query tool opens in new window. The event "StopEventPropogation" was not
> working.
>
> Please find the attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2016-07-13 11:35 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-07-11 08:13 [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime Surinder Kumar <[email protected]>
2016-07-13 11:35 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox