public inbox for [email protected]
help / color / mirror / Atom feedFrom: Surinder Kumar <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection
Date: Thu, 15 Sep 2016 14:54:21 +0530
Message-ID: <CAM5-9D_qV=1MwkN9UykmU0wgOAcccToXdZKCip-ft8qd2NFrnA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyNU5zTV9dermPbd1zN5nH7UnMt9fFt+7QhETjTn+0azQ@mail.gmail.com>
References: <CAM5-9D9RoouRYNk=7m+Khe22=1CEcJtXzutQYrnqJP2M=jNY8g@mail.gmail.com>
<CA+OCxoxDWXefwTOWHhLkXJ7BK=CajDhEMkuwzWzUxVBR_ResLQ@mail.gmail.com>
<CAM5-9D8apZstsBsk+dg7muOrmDX5vVU_DgDDDapO-kpnD7Yqyg@mail.gmail.com>
<CA+OCxoyNU5zTV9dermPbd1zN5nH7UnMt9fFt+7QhETjTn+0azQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On Thu, Sep 15, 2016 at 2:47 PM, Dave Page <[email protected]> wrote:
> Thanks, applied.
>
> One minor tweak to look at - in firefox, the width of the left margin
> in the query tool changes when you add a line, if the font size in
> preferences is not set to 1em. I think the width is initially sized
> for the font, then gets adjusted as you hit return. This doesn't seem
> to affect Chrome, and is only a minor annoyance in Firefox.
>
Ok, I will look into it.
>
> On Thu, Sep 15, 2016 at 10:04 AM, Surinder Kumar
> <[email protected]> wrote:
> > Hi
> >
> > Please find updated patch.
> >
> > On Thu, Sep 15, 2016 at 1:38 PM, Dave Page <[email protected]> wrote:
> >>
> >> (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM1579.patch
> >> error: patch failed: web/pgadmin/static/css/overrides.css:53
> >> error: web/pgadmin/static/css/overrides.css: patch does not apply
> >>
> >> Please rebase!
> >>
> >> On Thu, Sep 15, 2016 at 8:54 AM, Surinder Kumar
> >> <[email protected]> wrote:
> >> > Hi
> >> >
> >> > Please find the attached patch patch with following changes:
> >> >
> >> > 1) Implemented CodeMirror addon 'simplescrollbars'.
> >> >
> >> > 2) The CodeMirror instance of query tool was not rendering into
> >> > wcDocker's
> >> > 'pg-panel-content' div. it renders outside the div, due to which it
> took
> >> > little more time investigating why scrollbars doesn't appear in
> editor.
> >> >
> >> > 3) Add new css specific to query tool.
> >> >
> >> >
> >> > Please review.
> >> >
> >> > Thanks,
> >> > Surinder Kumar
> >> >
> >> >
> >> >
> >> > --
> >> > Sent via pgadmin-hackers mailing list ([email protected]
> )
> >> > To make changes to your subscription:
> >> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >> >
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection
In-Reply-To: <CAM5-9D_qV=1MwkN9UykmU0wgOAcccToXdZKCip-ft8qd2NFrnA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox