public inbox for [email protected]  

help / color / mirror / Atom feed

From: Surinder Kumar <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only
Date: Fri, 23 Sep 2016 10:29:26 +0530
Message-ID: <CAM5-9D_szaiOK8Ff1D5RDLTLBviMknaOV3po5Ven_pZo7g74HA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoziDJ602ijijUsVDOgP8jwHpqpKMBxXeY_9amcE_4bUOg@mail.gmail.com>
References: <CAM5-9D_+dUN79tJoK35Vq2oXLybeBwVFPFKHmF5NPKg6HR_c3Q@mail.gmail.com>
	<CA+OCxoziDJ602ijijUsVDOgP8jwHpqpKMBxXeY_9amcE_4bUOg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

​Actually It doesn't broke anywhere, instead It runs successfully. On
debugging I found that it runs the subprocess.Popen() utility but it
doesn't run internally the pg_dump utitliy. On running the same command on
windows cmd prompt it works.
Then on setting parameters close_fds=False and cmd_shell=True, It works.
I ran backup in Google Chrome.


On Thu, Sep 22, 2016 at 6:35 PM, Dave Page <[email protected]> wrote:

> Can you explain what was broken exactly please? Backups work fine for
> me without the patch - and whilst they also work with it, I now get an
> ugly command shell window flash up which I didn't before.
>
> On Wed, Sep 21, 2016 at 11:48 AM, Surinder Kumar
> <[email protected]> wrote:
> > Hi
> >
> > While working on RM1391 I found another issue 'Backup is not working on
> > windows".
> >
> > The reason is that the process executor which uses subprocess Popen() to
> > execute job fails when we pass close_fds=True and shell=False in windows.
> >
> > Now we are settings close_fds=False and shell=True to fix it. These
> settings
> > are specific to windows only.
> >
> > Please review the attached patch.
> >
> >
> > Thanks,
> > Surinder Kumar
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list ([email protected])
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only
  In-Reply-To: <CAM5-9D_szaiOK8Ff1D5RDLTLBviMknaOV3po5Ven_pZo7g74HA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox