public inbox for [email protected]  

help / color / mirror / Atom feed
From: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab
Date: Mon, 8 Feb 2021 17:38:40 +0530
Message-ID: <CAM9w-_=47=PZKvD6W5Z8RzYm6wg_vtP5=njtkxP8_jBN0S976Q@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdR7-JE+Xg_6jjREjXh3tdhJ+gaQ74WPEbf5K6d2s0WvA@mail.gmail.com>
References: <CAM9w-_mX2hfkH83=LuKYJ0tSBsW_H122hQAA6PyHp7NdgGNi3g@mail.gmail.com>
	<CANxoLDdR7-JE+Xg_6jjREjXh3tdhJ+gaQ74WPEbf5K6d2s0WvA@mail.gmail.com>

Hi,

The changes for not calling the ajax until the panel is focused were missed
in the last patch. Please review the attached.

On Wed, Feb 3, 2021 at 1:00 PM Akshay Joshi <[email protected]>
wrote:

> Thanks, patch applied.
>
> On Tue, Feb 2, 2021 at 5:44 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached patch will allow closing Statistics, Dependencies, Dependants
>> tabs. The tabs can be added back by right clicking on the tab strip and
>> selecting "Add panel", similar to that of Dashboard.
>> Changes are also made to make sure statistics, dependencies, dependants
>> are fetched only when they're visible, to avoid unnecessary ajax calls.
>>
>> Please review.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>> <http://edbpostgres.com;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"


Attachments:

  [application/octet-stream] RM5091.part2.patch (762B, 3-RM5091.part2.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/static/js/panel.js b/web/pgadmin/browser/static/js/panel.js
index da7cb2adb..bf9e874ce 100644
--- a/web/pgadmin/browser/static/js/panel.js
+++ b/web/pgadmin/browser/static/js/panel.js
@@ -200,9 +200,9 @@ define(
 
         if (eventName == 'panelClosed') {
           /* Pass the closed flag also */
-          module.toggleVisibility.call(module, [false, true]);
+          module.toggleVisibility.call(module, false, true);
         } else if (eventName == 'panelVisibilityChanged') {
-          module.toggleVisibility.call(module, [pgBrowser.docker.findPanels(this._type)[0].isVisible()]);
+          module.toggleVisibility.call(module, pgBrowser.docker.findPanels(this._type)[0].isVisible(), false);
         }
       },
 


view thread (6+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM5091] Option to hide Statistics, Dependencies, Dependants tab
  In-Reply-To: <CAM9w-_=47=PZKvD6W5Z8RzYm6wg_vtP5=njtkxP8_jBN0S976Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox