Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases
Date: Mon, 4 Feb 2019 14:18:37 +0530
Message-ID: <CAM9w-_=60dr7b2zdo9HV6gKPbNPBZKQT+FYiYNZBHDz=DND8kw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcbkCh0gdPYKZqJacffVkuXHRhWwPBXdLXJbv7UOkhaQQ@mail.gmail.com>
References: <CAM9w-_mx9D_W-H3x3HGq_pEcBiT7V65TWrW1B+Vin_VPXp=vEw@mail.gmail.com>
	<CA+OCxozDzm8EpLTux7-C=wy3XZSpUHdCxFKo=9dv+eWKsbJD5A@mail.gmail.com>
	<CAM9w-_n=7XEuFW+Vzi+xQgiXoJRdHu5-RrPS1QNwP7Ew9v6qdQ@mail.gmail.com>
	<CA+OCxowUyiAP7rrV1nttj4kpKUednObSkVYoEbhtMvqb0CV8Ng@mail.gmail.com>
	<CAM9w-_mR80KgZa5vSODppxJzushpWt14p2+Yo-6hdAJvE4WFmA@mail.gmail.com>
	<CAM9w-_koTkQyNKkEKBdJ9tTJ74gcSD59_YvOqA_iaiT-xACShQ@mail.gmail.com>
	<CA+OCxoyx-epUZ0n1wSoWWYjYyyVnuSWtoudMaChtJ3wO+_gaJQ@mail.gmail.com>
	<CANxoLDce2y20K18cALcn09LeunwJ=FxBEsJmyWx5FsM07Gs+YA@mail.gmail.com>
	<CANxoLDcbkCh0gdPYKZqJacffVkuXHRhWwPBXdLXJbv7UOkhaQQ@mail.gmail.com>

Hi Akshay,

I tried to simulate, but no luck. It works on my system :(

On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi <[email protected]>
wrote:

> Hi Aditya
>
> I have applied your patch but following test cases are failing
> consistently:
>
>    - CopySelectedQueryResultsFeatureTest
>    - QueryToolAutoCompleteFeatureTest
>
> I have verified your patch on Mac OSX and Ubuntu. Chrome Version
> 71.0.3578.98
>
> On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi <
> [email protected]> wrote:
>
>>
>>
>> On Tue, 29 Jan 2019, 19:09 Dave Page <[email protected] wrote:
>>
>>> Akshay, can you look at this please?
>>>
>>
>>     Sure.
>>
>>>
>>> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal
>>> <[email protected]> wrote:
>>> >
>>> > Hi Hackers,
>>> >
>>> > Attached is the updated patch. I have changed fill_input_by_field_name
>>> function to use javascript to set values of text boxes and the selector is
>>> changed from xpath to CSS with a :not(:disabled) clause. With this, test
>>> case will fail if tried to set the value of a disabled input.
>>> >
>>> > Kindly review.
>>> >
>>> >
>>> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal <
>>> [email protected]> wrote:
>>> >>
>>> >>
>>> >>
>>> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page <[email protected]> wrote:
>>> >>>
>>> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal
>>> >>> <[email protected]> wrote:
>>> >>> >
>>> >>> > Hi Dave,
>>> >>> >
>>> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page <[email protected]>
>>> wrote:
>>> >>> >>
>>> >>> >> Hi
>>> >>> >>
>>> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
>>> >>> >> <[email protected]> wrote:
>>> >>> >> >
>>> >>> >> > Hi Hackers,
>>> >>> >> >
>>> >>> >> > Attached is the patch to fix failing SQL editor related feature
>>> tests.
>>> >>> >> > The failure is occurring mostly because of send_keys function
>>> of selenium which sometimes does not input the complete text. The change
>>> will use Codemirror javascript object to set the text.
>>> >>> >> >
>>> >>> >> > I have also added new args flag "--modules" which can be used
>>> after --pkg where you can test a specific module file under the pkg. This
>>> is not so useful for build but definitely helpful for the developers.
>>> >>> >>
>>> >>> >> One of the most common failures I see is failure to fill in the
>>> >>> >> details on the Add Server dialogue (it might type half of an
>>> entry,
>>> >>> >> then just hang). Should we get rid of all uses of send_keys?
>>> >>> >
>>> >>> > Setting the text using javascript executor can be done. send_keys
>>> simulate an actual person,  so if you try to set a disabled text box using
>>> send_keys, it won't. Places where disabled fields doesn't matter, send_keys
>>> can be removed.
>>> >>>
>>> >>> Can't we just do something like:
>>> >>>
>>> >>> if input.disabled == false:
>>> >>>   input.value = 'Foo';
>>> >>> else:
>>> >>>   raise exception ....
>>> >>
>>> >> I'll check if this can be done. Will get back.
>>> >>>
>>> >>>
>>> >>> --
>>> >>> Dave Page
>>> >>> Blog: http://pgsnake.blogspot.com
>>> >>> Twitter: @pgsnake
>>> >>>
>>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>>> >>> The Enterprise PostgreSQL Company
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Thanks and Regards,
>>> >> Aditya Toshniwal
>>> >> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> >> "Don't Complain about Heat, Plant a tree"
>>> >
>>> >
>>> >
>>> > --
>>> > Thanks and Regards,
>>> > Aditya Toshniwal
>>> > Software Engineer | EnterpriseDB Software Solutions | Pune
>>> > "Don't Complain about Heat, Plant a tree"
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases
  In-Reply-To: <CAM9w-_=60dr7b2zdo9HV6gKPbNPBZKQT+FYiYNZBHDz=DND8kw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox