public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4] Update require.js library to latest version
Date: Tue, 4 May 2021 17:29:52 +0530
Message-ID: <CAM9w-_==t+j+peJ+UmpdbCS_pG9eOFbHXr8jeKdgHAUVD3X0Mw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDefBihLwc43s7GF_Ks_pqFjb5_JHL_G5vQaczCs03fH=w@mail.gmail.com>
References: <CAKKotZQA_-+6gsj=VUVY6dmAWqVhRfG5-smrd+YBFv9MqqGH1A@mail.gmail.com>
	<CANxoLDefBihLwc43s7GF_Ks_pqFjb5_JHL_G5vQaczCs03fH=w@mail.gmail.com>

Hi Akshay,

Since we're using it from the vendor directory, please yarn remove requirejs to
remove it from the package.json file.
Other than that, the patch looks good to me.

On Tue, May 4, 2021 at 5:08 PM Akshay Joshi <[email protected]>
wrote:

> Hi Aditya,
>
> Can you please review it?
>
> On Tue, May 4, 2021 at 2:07 PM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA patch to update the require.js library to the latest version.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> *EDB*
>> *POWER TO POSTGRES*
>> https://www.edbpostgres.com
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4] Update require.js library to latest version
  In-Reply-To: <CAM9w-_==t+j+peJ+UmpdbCS_pG9eOFbHXr8jeKdgHAUVD3X0Mw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox