public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY
Date: Thu, 27 Jun 2019 10:01:24 +0530
Message-ID: <CAM9w-_=D2m7n7SAMLL2ecViRLJGiONUZeEtLhDA01kA7v7QPGQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxox4VmAtwvWmZdZ9a=1KyR5yKDSQPTEi7rjahqfEAVWh_w@mail.gmail.com>
References: <CAM9w-_ntCvQ6DOq5tz4j=BJSifQi+TX3jrOgAcMF1nDsGn6UNg@mail.gmail.com>
	<CA+OCxox4VmAtwvWmZdZ9a=1KyR5yKDSQPTEi7rjahqfEAVWh_w@mail.gmail.com>

Hi,

On Wed, Jun 26, 2019 at 8:22 PM Dave Page <[email protected]> wrote:

> Hi
>
> Something isn't working correctly - I turned on the summary option, and
> this is the query that was run when I hit the EXPLAIN button:
>
> EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING
> False,SUMMARY False,BUFFERS False) select * from pg_tables
>

> Aside from the formatting (s/True/true, s/False/false, missing spaces
> etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle
> caches, rebundled etc.
>
I think I misunderstood the documents -
https://www.postgresql.org/docs/12/sql-explain.html. Few of the parameters
are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will make the
changes, along with formatting to existing codes as well.

>
> Shouldn't there also be documentation updates?
>
Yeah. (I always miss that :/)

>
> On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to add support for SETTINGS(v12+) and SUMMARY(v10+)
>> explain options. These options will be visible only if version is supported.
>>
>> I have also created and fixed RM4395. The explain options changed on one
>> query tool should not change explain options on other query tools or
>> preferences. The initial values will be taken from preferences are usual.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY
  In-Reply-To: <CAM9w-_=D2m7n7SAMLL2ecViRLJGiONUZeEtLhDA01kA7v7QPGQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox