public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Fahar Abbas <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin4 v4.10 candidate builds
Date: Tue, 2 Jul 2019 17:31:01 +0530
Message-ID: <CAM9w-_=DhB-Xn9oXCfyV9TKidD4kYDySQiH_NCoDph7a4rY8eg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdqbSa=446BRPLfKG6pUtCzuh71Qctk-1oNWzb1+xYYiQ@mail.gmail.com>
References: <CANxoLDdgYxW8z89wNA88aEOVfVsE2DB-w1d8Qko7mnKjEpB7Gw@mail.gmail.com>
<CAJFwRrOO0H2Z_ohCT8prz-AVBz3QP27=b+HcYkbtReG8=TXsFw@mail.gmail.com>
<CANxoLDdqbSa=446BRPLfKG6pUtCzuh71Qctk-1oNWzb1+xYYiQ@mail.gmail.com>
Hi,
The issue still persists. I have checked the code and found that
CompareVersions(Version, '{#MyAppFullVersion}') = -1, this should be 1 and not
-1.
Attached is the patch.
Sorry for trouble to build again. :/
On Tue, Jul 2, 2019 at 4:39 PM Akshay Joshi <[email protected]>
wrote:
> Hi Fahar
>
> We have fixed RM #4421. Candidate builds and source can be found at
> https://developer.pgadmin.org/builds/2019-07-02-1/ .
> There is some problem with the wheel packages, will check that. Meanwhile
> can you please test the builds for upgrade issue.
>
> On Tue, Jul 2, 2019 at 10:55 AM Fahar Abbas <[email protected]>
> wrote:
>
>> Hi,
>>
>> Here is the showstopper issue for pgadmin4 4.10:
>>
>> https://redmine.postgresql.org/issues/4421
>>
>> Kind Regards,
>>
>> On Fri, Jun 28, 2019 at 8:21 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi All,
>>>
>>> Due to an showstopper issue found in pgAdmin v4.9, we will have to
>>> release pgAdmin4 v4.10 early. Candidate builds and source can be found
>>> at https://developer.pgadmin.org/builds/2019-06-28-1/
>>>
>>> Fahar, can you please verify it for release on Tuesday (2nd July).
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Fahar Abbas
>> QMG
>> EnterpriseDB Corporation
>> Phone Office: +92-51-835-8874
>> Phone Direct: +92-51-8466803
>> Mobile: +92-333-5409707
>> Skype ID: *live:fahar.abbas*
>> Website: www.enterprisedb.com
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] win.ver_compare_v3.patch (622B, 3-win.ver_compare_v3.patch)
download | inline diff:
diff --git a/pkg/win32/installer.iss.in b/pkg/win32/installer.iss.in
index 7fda5b0d..7deb925f 100644
--- a/pkg/win32/installer.iss.in
+++ b/pkg/win32/installer.iss.in
@@ -179,7 +179,7 @@ begin
begin
UpgradeMode := True;
RegQueryStringValue(HKEY_LOCAL_MACHINE,'Software\{#MyAppName}\{#MyAppVersion}', 'Version', Version);
- if CompareVersions(Version, '{#MyAppFullVersion}') = -1 then
+ if CompareVersions(Version, '{#MyAppFullVersion}') = 1 then
begin
MsgBox(ExpandConstant('{cm:NewerVersionExists}' + '(v' + Version + ') is already installed' ), mbInformation, MB_OK);
Result := False;
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgAdmin4 v4.10 candidate builds
In-Reply-To: <CAM9w-_=DhB-Xn9oXCfyV9TKidD4kYDySQiH_NCoDph7a4rY8eg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox