public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM6935] Wrong SQL generated when modifying existing table in table dialog
Date: Tue, 19 Oct 2021 14:43:00 +0530
Message-ID: <CAM9w-_=EX22cEDDNXB7L4qvs+4mqmyKcwvD5x8O=J49CrAJHKA@mail.gmail.com> (raw)
Hi Hackers,
Attached patch fixes the issue where wrong SQL is generated when deleting
and renaming table columns together.
Please review.
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM6935.patch (815B, 3-RM6935.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/SchemaView/index.jsx b/web/pgadmin/static/js/SchemaView/index.jsx
index 1f326f0da..5f3833d54 100644
--- a/web/pgadmin/static/js/SchemaView/index.jsx
+++ b/web/pgadmin/static/js/SchemaView/index.jsx
@@ -176,7 +176,7 @@ function getChangedData(topSchema, viewHelperProps, sessData, stringify=false, i
/* If the id attr value is present, then only changed keys can be passed.
Otherwise, passing all the keys is useful */
- let idAttrValue = _.get(origVal, [field.id, rowIndx, field.schema.idAttribute]);
+ let idAttrValue = _.get(sessVal, [field.id, rowIndx, field.schema.idAttribute]);
if(_.isUndefined(idAttrValue)) {
change['changed'].push({
...changedRow,
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin][RM6935] Wrong SQL generated when modifying existing table in table dialog
In-Reply-To: <CAM9w-_=EX22cEDDNXB7L4qvs+4mqmyKcwvD5x8O=J49CrAJHKA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox