public inbox for [email protected]  
help / color / mirror / Atom feed
From: Aditya Toshniwal <[email protected]>
To: Sahil Harpal <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Cc: [email protected]
Cc: Ashesh Vashi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: Akshay Joshi <[email protected]>
Subject: Re: Pgadmin4 System Stats Extension Design
Date: Mon, 7 Aug 2023 11:00:39 +0530
Message-ID: <CAM9w-_=KM9+onud=Co54voWNZXymOzzCkmMxfCjkU_-sNOOViQ@mail.gmail.com> (raw)
In-Reply-To: <CAKi=nncNHn9D8L-R3HmBPGN+zcBsbg_ceXE3O-XoASwMq-pzKg@mail.gmail.com>
References: <CAKi=nneJvdbFyeDKnuQTVEnhNK0Zjdx5TWSwGUUSZO9YTC5E7Q@mail.gmail.com>
	<CANxoLDfO4BE0xvGLA3EBYyAzt3hCmuRcMY_pR3Zci9nPbL7P1Q@mail.gmail.com>
	<CAKi=nndnvAwgXVC=i=x3sSxNS9UCfks+EQWEjx8n5=u9CCP8og@mail.gmail.com>
	<CANxoLDeNzZkxYEnLdkFMkugvk7_k+BDSt6AoH83aaMkP+VZirQ@mail.gmail.com>
	<CAM9w-_mC2JKvxKKRwF7xCzoggoo0_XqBgUyqWDxXqSRQs_a0eg@mail.gmail.com>
	<CAKi=nncQ+OqkJ2PfvNNs40h5PfkO57YKTMEXdYeOpxUXhTzj5A@mail.gmail.com>
	<CA+OCxowriuEED8BC7DRZKwCM3dOfNaDWhf+vhJsH2PWq88yc7w@mail.gmail.com>
	<CAKi=nncY7wdMyqT2tKRAVWDaFSsgUS_qnOz0aifd-BorScUNSw@mail.gmail.com>
	<CA+OCxoyog3cqhZcEQ1xenmHUFMLM+VS8j91GM_RnU3VK8bGjaQ@mail.gmail.com>
	<CAKi=nncGiLTK36jQWnGL-0DToo4qTqojf+iLbDvRTfk2z_48Uw@mail.gmail.com>
	<CA+OCxowEmnWJHRa=QnuZpn42Cn594XZVduMPJuOg5MbdeQx0aw@mail.gmail.com>
	<CAKi=nnfMHZSGP3G+gS9JSLNp2C=BHF2ztsz6W0mpBREc4y=hiQ@mail.gmail.com>
	<CA+OCxowt2XSCEOxZ+Mz1CzMGQv5MCNV+GZO2b3E5PtZj1YgYOA@mail.gmail.com>
	<CAKi=nndoS4g8MmOBD6wZKCtGotpmxDa17rq8-obv3B9MaSbYjg@mail.gmail.com>
	<CA+OCxozjkCkVOFabHbMP+1sZ+hKftXA6Z8q00c+A2=mYHKbcuQ@mail.gmail.com>
	<CAKi=nncko8TQVyGtEn_89DtZoztdhOA_e2-wSe8wROjZADgbXg@mail.gmail.com>
	<CAKi=nnfj2OcTBkUoWwMZ5YifExgrxs9Pbt42-2W1+n32LEmgvQ@mail.gmail.com>
	<CAG7mmow-bPFycSZeY_-=JbhmdH7qHud2GHiiZTfcNPhnsruQaA@mail.gmail.com>
	<CAKi=nnfeEf6dQYcDyUExJK+1Xo5NgCHrpgfZPjS56B2rrUmd=w@mail.gmail.com>
	<CAM9w-_=-jmhjh9Mp98pvwBxp_DDoeMexnR2Y23+=-wR+tsDOiQ@mail.gmail.com>
	<CAKi=nneNLFiOUPQ16ZzO1RM8K8V=qoqa=AtmewkRzLjnjJhyUA@mail.gmail.com>
	<CAFOhELe-EAiVN6YjmAo1VjW-b+Bw3yPC6Ghxy=X6P-y4EF_EgA@mail.gmail.com>
	<CAKi=nndAi2iBN1P5y+XWdTa9EnL5b_FzhK4AG_9duUKxZE5=fw@mail.gmail.com>
	<CAKi=nndU8oESoER=MF7yaaUKiNd1fV7GDECGgLv_jumxs8EmTQ@mail.gmail.com>
	<CAFOhELdpnz1o-CYCmH=3x2u6XMWDXd6gbiWejL3dMq+LSu8QDQ@mail.gmail.com>
	<CAFOhELdT30L7OYj3MbQtkaHLHaRuMP3inV4t_wHkiJBOiJ=8TA@mail.gmail.com>
	<CAKi=nncg3M=ZE9JTzVYb-ox83quNO8i_=C3_34AhX1wckk0mbA@mail.gmail.com>
	<CAM9w-_=5Dnu4Dn9tg77GtAtaV7=vgyeSqkq0uLkt_c_K1Om2rg@mail.gmail.com>
	<CAKi=nncNHn9D8L-R3HmBPGN+zcBsbg_ceXE3O-XoASwMq-pzKg@mail.gmail.com>

Hi Sahil,

On Sun, Aug 6, 2023 at 1:21 PM Sahil Harpal <[email protected]>
wrote:

> Hi Aditya,
> On Thu, 3 Aug 2023 at 09:32, Aditya Toshniwal <
> [email protected]> wrote
>
>> Because it is the default behaviour of streaming. You can add a prop
>> reverse=true to StreamingChart and change the code ret.reverse(); based
>> on condition.
>>
> So basically, you are suggesting to add one additional property to the
> streaming chart, right? Based on its value, apply ret.reverse(). This means
> if reverse is true, apply ret.reverse(), otherwise don't. But it is
> required to reverse our data every time, otherwise, I believe the most
> recent data point will be at the beginning of our plot.
> I've tried one more approach here. If our data array is full, this graph
> shifting won't happen. So, if we initialize our data list with null values,
> there won't be any visible shift. What do you think about this solution?
>
I would suggest changing the behaviour in StreamingChart so that it can be
used at other places. If you want to reverse it then you can still do it. I
had achieved reverse direction with the following piece of code. Basically,
creating an array of 75 points, filling it with available points and
reverse. You can change it based on reverse=true flag. In your case, simply
reverse, not need of 75 points.
Array.from(new Array(xRange).keys()),
...(data.datasets?.map((d)=>{
let ret = [...d.data];
ret.reverse();
return ret;
})??{}),

>
> Unrelated to this, I think instead of showing disk sizes in bytes you can
>> show them in a human readable format like below used in Statistics tab of
>> Tables collection node.
>>
> Sure I'll do this!
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"


view thread (106+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Pgadmin4 System Stats Extension Design
  In-Reply-To: <CAM9w-_=KM9+onud=Co54voWNZXymOzzCkmMxfCjkU_-sNOOViQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox