public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Karan Takalkar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Re : [BUG #4943]
Date: Mon, 9 Dec 2019 15:24:58 +0530
Message-ID: <CAM9w-_=KyZkcHFg9g1esMq7mSiAEYqaC1hWcFiqnj4W8MyPk0w@mail.gmail.com> (raw)
In-Reply-To: <CADiZPH7qT7PVSrwduvL8Sa6N2W27NkP4EcsycmyygokYxXaFUQ@mail.gmail.com>
References: <CADiZPH7qT7PVSrwduvL8Sa6N2W27NkP4EcsycmyygokYxXaFUQ@mail.gmail.com>
++pgadmin-hackers
Hi Karan,
It is good to know that you're contributing.
I would suggest {server name}/{db name} as name instead of did is better
for UX. You can get the db name from conn object and server name using the
sid (refer - web/pgadmin/browser/server_groups/servers/__init__.py)
On Mon, Dec 9, 2019 at 3:11 PM Karan Takalkar <[email protected]> wrote:
> Hi,
>
> I have been working on #4943 ("Database connected" success message itself
> is not enough) added by you on pgAdmin4 issues.
> I want to know what details of database should be included in success
> message.(i have added 'did')
>
> The success message can be modified by altering json response in the
> connect method in file
> PGADMIN_SRC/web/pgadmin/browser/server_groups/servers/databases/__init__.py.
> please have a look at the screenshots attached.
>
> original:
> info=_( "Database connected.")
> new:
> info=_("Postgres version/{0} Database connected.".format(did))
>
> Regards,
> Karan
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Re : [BUG #4943]
In-Reply-To: <CAM9w-_=KyZkcHFg9g1esMq7mSiAEYqaC1hWcFiqnj4W8MyPk0w@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox