public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Sahil Harpal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Khushboo Vashi <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Subject: Re: Pgadmin4 System Stats Extension Design
Date: Mon, 4 Sep 2023 11:17:18 +0530
Message-ID: <CAM9w-_=LrLS1G48noXv+Oa9vd-9sYCoP-enOX_DUcxF2eitiFQ@mail.gmail.com> (raw)
In-Reply-To: <CAKi=nnc+L62NPnxZV_YKwB_GC5GXyC8w4XGLbNTq+HduaXkumA@mail.gmail.com>
References: <CAKi=nnc6Ze8QWBmSHe9YBYciWeDzMf=-rw9BgyNocFSokrpi6w@mail.gmail.com>
<CAKi=nneuTPLMppZaAm-Y1X=4mY3UnbkbJAMCHF=Fu-2+kateRg@mail.gmail.com>
<CAFOhELdhcYr9NBNrkEAWt_cwP77U2ANRK4xonqKA1p6WpMBdMA@mail.gmail.com>
<CAKi=nnfSoagHGwa4To7ND39Sb0qcUVBsL2HZB0X4d_4qAus2Nw@mail.gmail.com>
<CAKi=nndD92uV-RifeDJqs_3YV+ABWiN1_iMLUi7Zf1AaHzwM0w@mail.gmail.com>
<CAFOhELeVGiCarA9-AK_Wi9EpNxKrF4Ev7VNNQCD=LZy9OM0aqg@mail.gmail.com>
<CAFOhELe4m5unS6gTBsy=2bO-T-yq4HEL7RDjUf6G_TPCsi+o7g@mail.gmail.com>
<CAKi=nndX9bMyUX6_51b_Jz2P2xSVxNY7fvShb_Yq1TLHeURvUg@mail.gmail.com>
<CAFOhELdHKD9xFhfER7fshNQa5rd0ZhVtCKUarvOE_UVRoL08dw@mail.gmail.com>
<CAKi=nndgjKVmRhv7dzvpbUwVNAWEdii+0t_vBVpF81hdN6othw@mail.gmail.com>
<CAM9w-_=zDCeqwoO=nAA+HQA7fw96Uie5kwGHrNw-8sYZ=7CZ-g@mail.gmail.com>
<CAKi=nndr5jWnH7BBCSbELbVx9eij4hBTNR1_K_OoEYCZxomVQA@mail.gmail.com>
<CAM9w-_=MPe_2j0wYztR+11+qNdNp95OaKgcZhBmoi3Gvy8q4sw@mail.gmail.com>
<CAKi=nnc+L62NPnxZV_YKwB_GC5GXyC8w4XGLbNTq+HduaXkumA@mail.gmail.com>
Hi Sahil,
I have replied to the PR.
On Sun, Sep 3, 2023 at 2:31 AM Sahil Harpal <[email protected]>
wrote:
> Hi Aditya,
>
> I have made almost all of the requested changes and pushed the latest
> code. I just need a bit of clarification for a couple of suggestions that I
> have posted in the reviews.
>
> Thank you,
> Sahil
>
>
> On Thu, 31 Aug 2023 at 17:20, Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Sahil,
>>
>> OK fine. We will check it later. Not priority. Please also fix the
>> review raised on PR.
>>
>> On Thu, Aug 31, 2023, 16:17 Sahil Harpal <[email protected]>
>> wrote:
>>
>>> Hi Aditya,
>>> I have made all these changes except the StreamingChart issue. I tried
>>> filling an array with null values inside the StreamingChart component while
>>> initializing initialState but still the issue is not resolved.
>>> I have made following changes:
>>>
>>>> const initialState = [
>>>> Array.from(new Array(xRange).keys()),
>>>> ...(data.datasets?.map((d)=>{
>>>> let nullValues = new Array(xRange - d.data.length).fill(null);
>>>> let ret = [...nullValues, ...d.data];
>>>> ret.reverse();
>>>> return ret;
>>>> })??{}),
>>>> ];
>>>
>>>
>>> It works fine if we initialize the data array with the null values but
>>> I'm not getting why this is not working.
>>>
>>> Thank you,
>>> Sahil
>>>
>>>
>>> [image: Mailtrack]
>>> <https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&...; Sender
>>> notified by
>>> Mailtrack
>>> <https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&...; 31/08/23,
>>> 16:14:27
>>>
>>> On Mon, 28 Aug 2023 at 10:44, Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Sahil,
>>>>
>>>> I have few observations. You have added separate titles for graphs and
>>>> other tabular data. This is inconsistent with existing UI.
>>>> For example,
>>>> [image: image.png]
>>>> like here:
>>>> [image: image.png]
>>>>
>>>> [image: Screenshot 2023-08-28 at 10.28.59 AM.png]
>>>> like here:
>>>> [image: image.png]
>>>>
>>>> [image: image.png]
>>>>
>>>> [image: image.png]
>>>>
>>>> The dashboard goes blank when I change refresh rates.
>>>>
>>>> [image: image.png]
>>>>
>>>> And regarding filling with nulls to fix the reversing issue of graph -
>>>> you can do it in StreamingChart itself when setting initialState var, as it
>>>> is StreamingChart's responsibility to do it.
>>>> Next review will be on the PR directly.
>>>>
>>>>
>>>> On Sun, Aug 27, 2023 at 5:58 PM Sahil Harpal <[email protected]>
>>>> wrote:
>>>>
>>>>> Hello everyone,
>>>>>
>>>>> I have raised the PR
>>>>> <https://github.com/pgadmin-org/pgadmin4/pull/6721;.
>>>>> I would like to request you all to review the changes and provide your
>>>>> valuable feedback. Your insights and suggestions would be invaluable in
>>>>> ensuring the quality and accuracy of the codebase.
>>>>>
>>>>> Thank you,
>>>>> Sahil
>>>>>
>>>>> On Sun, 27 Aug 2023 at 07:13, Khushboo Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Sat, 26 Aug 2023, 11:36 Sahil Harpal, <[email protected]>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi Khushboo,
>>>>>>>
>>>>>>> On Mon, 21 Aug 2023 at 10:03, Khushboo Vashi <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Sahil, once the issues get resolved, please raise the PR and we
>>>>>>>> will do the final review there.
>>>>>>>>
>>>>>>> Could you please tell me to which branch I should raise the PR?
>>>>>>>
>>>>>> Master branch
>>>>>>
>>>>>>> Also, should I remove the code responsible for the static DonutChart
>>>>>>> of process information?
>>>>>>>
>>>>>>> Thank you,
>>>>>>> Sahil
>>>>>>>
>>>>>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>> <https://www.enterprisedb.com/;
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[image/png] image.png (62.5K, 3-image.png)
download | view image
[image/png] image.png (28.3K, 4-image.png)
download | view image
[image/png] Screenshot 2023-08-28 at 10.28.59 AM.png (93.6K, 5-Screenshot%202023-08-28%20at%2010.28.59%20AM.png)
download | view image
[image/png] image.png (21.2K, 6-image.png)
download | view image
[image/png] image.png (82.4K, 7-image.png)
download | view image
[image/png] image.png (193.0K, 8-image.png)
download | view image
[image/png] image.png (124.6K, 9-image.png)
download | view image
view thread (106+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Pgadmin4 System Stats Extension Design
In-Reply-To: <CAM9w-_=LrLS1G48noXv+Oa9vd-9sYCoP-enOX_DUcxF2eitiFQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox