public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][RM3865] Difficult to resize Query Tool
Date: Wed, 30 Jan 2019 12:32:30 +0530
Message-ID: <CAM9w-_=MWokjGRTBK8FnxGn==cEeHzNFi8c63q2f=x0RpiKHCg@mail.gmail.com> (raw)

Hi Hackers,

With my pull request for changes in wcDocker merged (
https://github.com/EnterpriseDB/wcDocker/commit/9cf81f03bb350b76b77a264f1db5d55391d5e424),
we are now able to increase the mouse hover area of the frame splitters
without increasing visible splitter lines width.
Attached is the patch for changes required in pgAdmin accordingly. I have
kept the total hover width as $splitter-hover-width:5px, which can be
changed.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


Attachments:

  [application/octet-stream] RM3865.patch (1.9K, 3-RM3865.patch)
  download | inline diff:
diff --git a/web/package.json b/web/package.json
index a554bbb5..0c2a1017 100644
--- a/web/package.json
+++ b/web/package.json
@@ -97,7 +97,7 @@
     "underscore": "^1.8.3",
     "underscore.string": "^3.3.4",
     "watchify": "~3.9.0",
-    "webcabin-docker": "git+https://github.com/EnterpriseDB/wcDocker/#25f6fda624c5469340da0c111a18545a4455973a",
+    "webcabin-docker": "git+https://github.com/EnterpriseDB/wcDocker/#9cf81f03bb350b76b77a264f1db5d55391d5e424",
     "wkx": "^0.4.5"
   },
   "scripts": {
diff --git a/web/pgadmin/static/scss/_webcabin.pgadmin.scss b/web/pgadmin/static/scss/_webcabin.pgadmin.scss
index 4fd92cdb..4af27da4 100644
--- a/web/pgadmin/static/scss/_webcabin.pgadmin.scss
+++ b/web/pgadmin/static/scss/_webcabin.pgadmin.scss
@@ -207,17 +207,25 @@
 }
 
 
-.wcSplitterBar {
+.wcSplitterBarLine {
   background-color: $panel-border-color;
   border: none;
 }
 
 .wcSplitterBarV {
-  width: $panel-border-width;
+  width: $splitter-hover-width;
+
+  & .wcSplitterBarLine {
+    width: $panel-border-width;
+  }
 }
 
 .wcSplitterBarH {
-  height: $panel-border-width;
+  height: $splitter-hover-width;
+
+  & .wcSplitterBarLine {
+    height: $panel-border-width;
+  }
 }
 
 .wcSplitterBarV.wcSplitterBarStatic {
diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss
index d622d180..600785fd 100644
--- a/web/pgadmin/static/scss/resources/_default.variables.scss
+++ b/web/pgadmin/static/scss/resources/_default.variables.scss
@@ -156,6 +156,9 @@ $footer-padding: 0.5rem;
 $footer-min-height: 2rem;
 $footer-height-calc: $footer-min-height+$footer-padding*2;
 
+// ($splitter-hover-width - $panel-border-width) should be even number to split evenly.
+$splitter-hover-width: 5px;
+
 $navbar-brand-bg: #222222; //place image url if image
 $navbar-brand-arrow-bg: #222222;
 $navbar-color-bg: $color-primary;

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][RM3865] Difficult to resize Query Tool
  In-Reply-To: <CAM9w-_=MWokjGRTBK8FnxGn==cEeHzNFi8c63q2f=x0RpiKHCg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox