public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin4][RM3865] Difficult to resize Query Tool 5+ messages / 4 participants [nested] [flat]
* [pgAdmin4][RM3865] Difficult to resize Query Tool @ 2019-01-30 07:02 Aditya Toshniwal <[email protected]> 0 siblings, 2 replies; 5+ messages in thread From: Aditya Toshniwal @ 2019-01-30 07:02 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, With my pull request for changes in wcDocker merged ( https://github.com/EnterpriseDB/wcDocker/commit/9cf81f03bb350b76b77a264f1db5d55391d5e424), we are now able to increase the mouse hover area of the frame splitters without increasing visible splitter lines width. Attached is the patch for changes required in pgAdmin accordingly. I have kept the total hover width as $splitter-hover-width:5px, which can be changed. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" Attachments: [application/octet-stream] RM3865.patch (1.9K, 3-RM3865.patch) download | inline diff: diff --git a/web/package.json b/web/package.json index a554bbb5..0c2a1017 100644 --- a/web/package.json +++ b/web/package.json @@ -97,7 +97,7 @@ "underscore": "^1.8.3", "underscore.string": "^3.3.4", "watchify": "~3.9.0", - "webcabin-docker": "git+https://github.com/EnterpriseDB/wcDocker/#25f6fda624c5469340da0c111a18545a4455973a", + "webcabin-docker": "git+https://github.com/EnterpriseDB/wcDocker/#9cf81f03bb350b76b77a264f1db5d55391d5e424", "wkx": "^0.4.5" }, "scripts": { diff --git a/web/pgadmin/static/scss/_webcabin.pgadmin.scss b/web/pgadmin/static/scss/_webcabin.pgadmin.scss index 4fd92cdb..4af27da4 100644 --- a/web/pgadmin/static/scss/_webcabin.pgadmin.scss +++ b/web/pgadmin/static/scss/_webcabin.pgadmin.scss @@ -207,17 +207,25 @@ } -.wcSplitterBar { +.wcSplitterBarLine { background-color: $panel-border-color; border: none; } .wcSplitterBarV { - width: $panel-border-width; + width: $splitter-hover-width; + + & .wcSplitterBarLine { + width: $panel-border-width; + } } .wcSplitterBarH { - height: $panel-border-width; + height: $splitter-hover-width; + + & .wcSplitterBarLine { + height: $panel-border-width; + } } .wcSplitterBarV.wcSplitterBarStatic { diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss index d622d180..600785fd 100644 --- a/web/pgadmin/static/scss/resources/_default.variables.scss +++ b/web/pgadmin/static/scss/resources/_default.variables.scss @@ -156,6 +156,9 @@ $footer-padding: 0.5rem; $footer-min-height: 2rem; $footer-height-calc: $footer-min-height+$footer-padding*2; +// ($splitter-hover-width - $panel-border-width) should be even number to split evenly. +$splitter-hover-width: 5px; + $navbar-brand-bg: #222222; //place image url if image $navbar-brand-arrow-bg: #222222; $navbar-color-bg: $color-primary; ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][RM3865] Difficult to resize Query Tool @ 2019-01-30 08:57 Akshay Joshi <[email protected]> parent: Aditya Toshniwal <[email protected]> 1 sibling, 0 replies; 5+ messages in thread From: Akshay Joshi @ 2019-01-30 08:57 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Thanks patch applied. On Wed, Jan 30, 2019 at 12:32 PM Aditya Toshniwal < [email protected]> wrote: > Hi Hackers, > > With my pull request for changes in wcDocker merged ( > https://github.com/EnterpriseDB/wcDocker/commit/9cf81f03bb350b76b77a264f1db5d55391d5e424), > we are now able to increase the mouse hover area of the frame splitters > without increasing visible splitter lines width. > Attached is the patch for changes required in pgAdmin accordingly. I have > kept the total hover width as $splitter-hover-width:5px, which can be > changed. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][RM3865] Difficult to resize Query Tool @ 2019-01-30 09:01 Ashesh Vashi <[email protected]> parent: Aditya Toshniwal <[email protected]> 1 sibling, 1 reply; 5+ messages in thread From: Ashesh Vashi @ 2019-01-30 09:01 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers; Aditya Toshniwal <[email protected]> Hi Dave, I was having conversation with Aditya about "What should be the mouse hover (resize selection) area of the splitters?". I asked him to set it to 5px. But - he has different opinion, was in favor to keep it around '11px'. Please advise. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com; *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi; On Wed, Jan 30, 2019 at 12:32 PM Aditya Toshniwal < [email protected]> wrote: > Hi Hackers, > > With my pull request for changes in wcDocker merged ( > https://github.com/EnterpriseDB/wcDocker/commit/9cf81f03bb350b76b77a264f1db5d55391d5e424), > we are now able to increase the mouse hover area of the frame splitters > without increasing visible splitter lines width. > Attached is the patch for changes required in pgAdmin accordingly. I have > kept the total hover width as $splitter-hover-width:5px, which can be > changed. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][RM3865] Difficult to resize Query Tool @ 2019-01-30 09:17 Akshay Joshi <[email protected]> parent: Ashesh Vashi <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Akshay Joshi @ 2019-01-30 09:17 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers; Aditya Toshniwal <[email protected]>; Ashesh Vashi <[email protected]> Hi Dave On Wed, Jan 30, 2019 at 2:32 PM Ashesh Vashi <[email protected]> wrote: > Hi Dave, > > I was having conversation with Aditya about "What should be the mouse > hover (resize selection) area of the splitters?". > I asked him to set it to 5px. > I have committed with 7px which looks good, but it would be good to have your opinion on this. You will have to run "Yarn Install" to test this. > > But - he has different opinion, was in favor to keep it around '11px'. > > Please advise. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com; > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi; > > > On Wed, Jan 30, 2019 at 12:32 PM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Hackers, >> >> With my pull request for changes in wcDocker merged ( >> https://github.com/EnterpriseDB/wcDocker/commit/9cf81f03bb350b76b77a264f1db5d55391d5e424), >> we are now able to increase the mouse hover area of the frame splitters >> without increasing visible splitter lines width. >> Attached is the patch for changes required in pgAdmin accordingly. I have >> kept the total hover width as $splitter-hover-width:5px, which can be >> changed. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB Software Solutions | Pune >> "Don't Complain about Heat, Plant a tree" >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][RM3865] Difficult to resize Query Tool @ 2019-01-31 13:36 Dave Page <[email protected]> parent: Akshay Joshi <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Dave Page @ 2019-01-31 13:36 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers; Aditya Toshniwal <[email protected]>; Ashesh Vashi <[email protected]> On Wed, Jan 30, 2019 at 10:17 AM Akshay Joshi <[email protected]> wrote: > Hi Dave > > On Wed, Jan 30, 2019 at 2:32 PM Ashesh Vashi < > [email protected]> wrote: > >> Hi Dave, >> >> I was having conversation with Aditya about "What should be the mouse >> hover (resize selection) area of the splitters?". >> I asked him to set it to 5px. >> > > I have committed with 7px which looks good, but it would be good to > have your opinion on this. You will have to run "Yarn Install" to test > this. > Seems fine to me. Thanks. > >> But - he has different opinion, was in favor to keep it around '11px'. >> >> Please advise. >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> <http://www.enterprisedb.com; >> >> >> *http://www.linkedin.com/in/asheshvashi* >> <http://www.linkedin.com/in/asheshvashi; >> >> >> On Wed, Jan 30, 2019 at 12:32 PM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> With my pull request for changes in wcDocker merged ( >>> https://github.com/EnterpriseDB/wcDocker/commit/9cf81f03bb350b76b77a264f1db5d55391d5e424), >>> we are now able to increase the mouse hover area of the frame splitters >>> without increasing visible splitter lines width. >>> Attached is the patch for changes required in pgAdmin accordingly. I >>> have kept the total hover width as $splitter-hover-width:5px, which can be >>> changed. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2019-01-31 13:36 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-01-30 07:02 [pgAdmin4][RM3865] Difficult to resize Query Tool Aditya Toshniwal <[email protected]> 2019-01-30 08:57 ` Akshay Joshi <[email protected]> 2019-01-30 09:01 ` Ashesh Vashi <[email protected]> 2019-01-30 09:17 ` Akshay Joshi <[email protected]> 2019-01-31 13:36 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox