public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox
@ 2019-01-21 09:54 Aditya Toshniwal <[email protected]>
  2019-01-21 10:53 ` Re: [pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox Akshay Joshi <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Aditya Toshniwal @ 2019-01-21 09:54 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Attached is a tiny patch to fix a bug where file format combo box value is
not retained when hidden files checkbox is toggled.

Kindly review.

-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


Attachments:

  [application/octet-stream] RM3840.patch (837B, 3-RM3840.patch)
  download | inline diff:
diff --git a/web/pgadmin/misc/file_manager/static/js/utility.js b/web/pgadmin/misc/file_manager/static/js/utility.js
index c714f154..93891fc7 100644
--- a/web/pgadmin/misc/file_manager/static/js/utility.js
+++ b/web/pgadmin/misc/file_manager/static/js/utility.js
@@ -1176,11 +1176,11 @@ define([
           };
 
           if (cb.checked) {
-            $('div.allowed_file_types select').val('*').trigger('change');
+            $('div.allowed_file_types select').trigger('change');
             data['is_checked'] = true;
           } else {
             // User wants to hide it again
-            $('div.allowed_file_types select').prop('selectedIndex', 0).trigger('change');
+            $('div.allowed_file_types select').trigger('change');
             data['is_checked'] = false;
           }
           // Save it in preference


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox
  2019-01-21 09:54 [pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox Aditya Toshniwal <[email protected]>
@ 2019-01-21 10:53 ` Akshay Joshi <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2019-01-21 10:53 UTC (permalink / raw)
  To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers

Thanks patch applied.

On Mon, Jan 21, 2019 at 3:24 PM Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is a tiny patch to fix a bug where file format combo box value is
> not retained when hidden files checkbox is toggled.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>


-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2019-01-21 10:53 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-21 09:54 [pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox Aditya Toshniwal <[email protected]>
2019-01-21 10:53 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox