public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Chethana Kumar <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM 5271] To change the switch control colors
Date: Wed, 18 Mar 2020 14:26:44 +0530
Message-ID: <CAM9w-_=k=auV3dPTx1SgxbjyA8A3Z+Wfnm-S6x=ekK17Wg8LmQ@mail.gmail.com> (raw)
In-Reply-To: <CAH4-4WvHttwdvs+KYcRhpTRGYFTRxz=yQZ5rGjFHjo2q+jg=tw@mail.gmail.com>
References: <CAKKotZQezDN2uY5Xu-iuV2eOqN=KXU0=MPmkJpnYGvRUnBF-0w@mail.gmail.com>
<CAH4-4WsyPJ++u9DrF08mH5R_NsuW9htW7WucxuZxkG=-djVe8w@mail.gmail.com>
<CAKKotZRymZtuez5iThP+NKWBrT0PDOPUsh-mn3wsAkzO5jstBA@mail.gmail.com>
<CAH4-4WvHttwdvs+KYcRhpTRGYFTRxz=yQZ5rGjFHjo2q+jg=tw@mail.gmail.com>
Hi Murtuza/Chethana,
Irrespective of what color you suggest, there is no need to add new
variables for switch buttons. It should use success for on and ternary for
off.
Having a separate green color for each and every control is absurd. If the
green changes, it should change for all.
On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar <
[email protected]> wrote:
> Let us discuss on a call for better clarity and the conclusion part we can
> put it on mail.
>
> ---
> Chethana kumar
>
> On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi Chethana,
>>
>> No it is not, As per current dark theme implementation we have used
>> primary color '#1a522b' for switch but the color you suggested is '#43A047'
>> for both theme.
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>>
>> On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar <
>> [email protected]> wrote:
>>
>>> Hi Murtuza,
>>>
>>> The changes are already incorporated so no worries :)
>>>
>>> Thanks,
>>>
>>> ---
>>> Chethana kumar
>>>
>>> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> Hello,
>>>>
>>>> As per discussion with Chethana, We need to make switch box color
>>>> change for light and dark theme, Color details provided by Chethana is
>>>> updated on ticket.
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>
>>> --
>>> Chethana Kumar
>>> Principal UI/UX Designer
>>> EnterpriseDB Corporation
>>>
>>> The Postgres Database Company
>>>
>>> P: +91 86981 57146
>>> www.enterprisedb.com
>>>
>>
>
> --
> Chethana Kumar
> Principal UI/UX Designer
> EnterpriseDB Corporation
>
> The Postgres Database Company
>
> P: +91 86981 57146
> www.enterprisedb.com
>
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][RM 5271] To change the switch control colors
In-Reply-To: <CAM9w-_=k=auV3dPTx1SgxbjyA8A3Z+Wfnm-S6x=ekK17Wg8LmQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox