public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5017] Use cheroot as default production server
Date: Fri, 27 Dec 2019 11:43:13 +0530
Message-ID: <CAM9w-_=wXSDhhEWhdQntX2zH41JGozDwrcmFnhZjSb1Aq08POw@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mmi1gW7cbg0J9wQ9m3AP0_m12GtctmbHY7+vBqDvrbMw@mail.gmail.com>
References: <CAM9w-_kHiZMhHZK+ZznADSHYrEH+SFxR0oTkZ3oBdDYCcGS85w@mail.gmail.com>
<CAG7mmowQhSn5m8=9WyNLmyLCkWfRq2Q+JVSDNoyQrwikcQ35Kg@mail.gmail.com>
<CAM9w-_ny_icvP7SCqAQ9CdeOnRWaAeeX4esSYkP2dHCQcjtXNA@mail.gmail.com>
<CAM9w-_mmi1gW7cbg0J9wQ9m3AP0_m12GtctmbHY7+vBqDvrbMw@mail.gmail.com>
Hi Hackers,
Turned out my pip was of older version. Upgrading pip solved the
jaraco.functools problem. pip downloaded the suitable version
automatically. Kindly ignore the previous patch.
On Tue, Dec 24, 2019 at 12:49 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> One of the dependencies of cheroot - jaraco.functools was released on
> 20th Dec (v 3.0.0) which removed the support below Python 3.6. So while
> installing cheroot (using pgAdmin wheel) on Python 3.5, it is failing.
> cheroot works fine with its previous version of jaraco.functools==2.0.0.
> I've raised the issue to cheroot -
> https://github.com/cherrypy/cheroot/issues/258.
> Please note, installers work fine as they are shipped with Python 3.7
> venv. Ref -
> https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2019-12-24/
> Attached is the patch to pin jaraco.functools to 2.0.0 in requirements so
> that it does not fail below Python 3.6.
>
> On Fri, Dec 20, 2019 at 6:21 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Ashesh,
>>
>> I had tried with - https://newrelic.com/ API to check Flask app
>> performance. To be honest, there was not a great difference in the
>> performance.
>> Per new relic, cheroot used slightly less CPU, with more RPM and, with
>> less response time.
>> Anyway, flask is still not recommended and cheroot looks a good option as
>> it is pure python and supports almost all OS.
>>
>> On Fri, Dec 20, 2019 at 1:34 PM Ashesh Vashi <
>> [email protected]> wrote:
>>
>>> Have you seen any improvements in performance?
>>>
>>> On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the patch to use https://pypi.org/project/cheroot/ instead
>>>> of current flask dev server. cheroot is a stable production ready server.
>>>> Plus, flask dev server is not recommended for production.
>>>> Code is changed to use cheroot only when DEBUG is False, otherwise you
>>>> the default flask server.
>>>>
>>>> Kindly review.
>>>>
>>>> --
>>>> Thanks and Regards,
>>>> Aditya Toshniwal
>>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin][RM5017] Use cheroot as default production server
In-Reply-To: <CAM9w-_=wXSDhhEWhdQntX2zH41JGozDwrcmFnhZjSb1Aq08POw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox