public inbox for [email protected]  
help / color / mirror / Atom feed
From: Aditya Toshniwal <[email protected]>
To: Pravesh Sharma <[email protected]>
Cc: [email protected]
Subject: Re: Require suggestions on UI changes
Date: Thu, 16 Nov 2023 21:01:38 +0530
Message-ID: <CAM9w-_k1h1gw+nO73z1LuO0rVHVzg=Od9Q2pDV97sohwGckxpA@mail.gmail.com> (raw)
In-Reply-To: <CA+36bxH1nh_vZuF9tX_HxHtdqWrQio=dD1gLeUCrqszkBuSpgg@mail.gmail.com>
References: <CA+36bxH1nh_vZuF9tX_HxHtdqWrQio=dD1gLeUCrqszkBuSpgg@mail.gmail.com>

Hi Pravesh,

I suggest we can move the "Custom return type?" switch above with default
as false and change "return type" to dropdown or text based on the switch.
No need for a "Custom return type" textbox.

On Thu, Nov 16, 2023 at 5:58 PM Pravesh Sharma <
[email protected]> wrote:

> Hi Team,
>
> I have made some UI changes for issue 6854
> <https://github.com/pgadmin-org/pgadmin4/issues/6854;. I have added a
> switch *Custom return type? *if enabled, an input text box will be
> visible in which the user can provide their desired return type, and when
> this switch is enabled return type select box will be disabled. This custom
> return type input and switch will be visible only when creating a new
> function.
>
> Please provide your suggestions and feedback if these changes look okay to
> you.
>
>
> Regards,
> Pravesh
> --
>
> <http://www.enterprisedb.com;
>
> Pravesh Sharma
>
> Software Engineer
>
> +91 9406461406
>
> www.enterprisedb.com
>
> Power to Postgres
>
> <https://www.linkedin.com/company/edbpostgres;
> <https://twitter.com/edbpostgres?lang=en;
> <https://www.facebook.com/EDBpostgres;
> <https://www.instagram.com/EDBpostgres/;
>


-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"


view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Require suggestions on UI changes
  In-Reply-To: <CAM9w-_k1h1gw+nO73z1LuO0rVHVzg=Od9Q2pDV97sohwGckxpA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox