public inbox for [email protected]  

help / color / mirror / Atom feed
From: Aditya Toshniwal <[email protected]>
To: [email protected]
Subject: pgAdmin4 form control error icon position change
Date: Wed, 21 Mar 2018 14:28:11 +0530
Message-ID: <CAM9w-_kJ0AN8xvPk2--KK_JHksOy48muUnku2_cQ1LzG+YyTDw@mail.gmail.com> (raw)

*Hi Team,*

This is regarding the position of error icon of a pgAdmin form control.
Below are the screenshots. As we can see, the error icon is overlapping the
control buttons like the drop down button, spinner up down buttons, etc.




We propose that we can move the error icon to the front of the label of the
form control. Below are screenshots.




Attached is the patch for the above changes.
Kindly review.
-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
Pune | Mob - 8055837949


Attachments:

  [image/png] image.png (11.6K, 3-image.png)
  download | view image

  [text/x-patch] pgadmin_ctrlerroricon.patch (1.4K, 4-pgadmin_ctrlerroricon.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/css/bootstrap.overrides.css b/web/pgadmin/static/css/bootstrap.overrides.css
index d2936a7..2ab44f0 100755
--- a/web/pgadmin/static/css/bootstrap.overrides.css
+++ b/web/pgadmin/static/css/bootstrap.overrides.css
@@ -269,7 +269,7 @@ iframe {
 
 .control-label {
     margin: 0px;
-    padding: 5px;
+    padding: 5px 25px 5px 5px;
     display: inline-block;
     vertical-align: middle;
 }
diff --git a/web/pgadmin/static/css/pgadmin.css b/web/pgadmin/static/css/pgadmin.css
index 6c1002c..666140e 100644
--- a/web/pgadmin/static/css/pgadmin.css
+++ b/web/pgadmin/static/css/pgadmin.css
@@ -732,7 +732,7 @@ lgg-el-container[el=md] .pg-el-lg-8,
   padding-top: 6px;
   padding-bottom: 6px;
   padding-left: 5px;
-  padding-right: 5px;
+  padding-right: 25px;
   display: inline-block;
   vertical-align: middle;
   min-height: 28px;
diff --git a/web/pgadmin/static/scss/_backform.overrides.scss b/web/pgadmin/static/scss/_backform.overrides.scss
index 2aa9460..b22c55a 100644
--- a/web/pgadmin/static/scss/_backform.overrides.scss
+++ b/web/pgadmin/static/scss/_backform.overrides.scss
@@ -8,14 +8,14 @@
     color: #d0021b;
   }
 
-  .pgadmin-controls:before {
+  .control-label:before {
     font: normal normal normal 16px/1 FontAwesome;
     content: "\f071";
     text-decoration: inherit;
     position: absolute;
     color: #d0021b;
-    right: 15px;
-    padding-top: 10px;
+    right: 6px;
+    padding-top: 6px;
     z-index: 1;
   }
 }


view thread (4+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: pgAdmin4 form control error icon position change
  In-Reply-To: <CAM9w-_kJ0AN8xvPk2--KK_JHksOy48muUnku2_cQ1LzG+YyTDw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox