public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin4 form control error icon position change
Date: Fri, 23 Mar 2018 09:57:53 +0000
Message-ID: <CA+OCxowkHXW0OTX18YmbVZnZcuLMpL4FTrwU2qAt+XcHAS4Eyw@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_kdah46=eY-UyvRFCdxujXu9o500MVrf+LUZSOw4eY1Zw@mail.gmail.com>
References: <CAM9w-_kJ0AN8xvPk2--KK_JHksOy48muUnku2_cQ1LzG+YyTDw@mail.gmail.com>
	<CAKKotZQtVVDGY__Nf5y7sX6O1Kb99gxyReWJGZwqNv29igBpew@mail.gmail.com>
	<CAM9w-_kdah46=eY-UyvRFCdxujXu9o500MVrf+LUZSOw4eY1Zw@mail.gmail.com>

Thanks Aditya, patch applied.

On Wed, Mar 21, 2018 at 9:34 AM, Aditya Toshniwal <
[email protected]> wrote:

> Created - https://redmine.postgresql.org/issues/3226
>
>
> On Wed, Mar 21, 2018 at 2:51 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hello Aditya,
>>
>> Could you please create new RM
>> <https://redmine.postgresql.org/projects/pgadmin4; for the issue, so
>> that we can keep track of changes, It will be difficult for us to keep
>> track of email for the details.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Wed, Mar 21, 2018 at 2:28 PM, Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>>
>>> *Hi Team,*
>>>
>>> This is regarding the position of error icon of a pgAdmin form control.
>>> Below are the screenshots. As we can see, the error icon is overlapping the
>>> control buttons like the drop down button, spinner up down buttons, etc.
>>>
>>>
>>>
>>>
>>> We propose that we can move the error icon to the front of the label of
>>> the form control. Below are screenshots.
>>>
>>>
>>>
>>>
>>> Attached is the patch for the above changes.
>>> Kindly review.
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions
>>> Pune | Mob - 8055837949 <(805)%20583-7949>
>>>
>>
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions
> Pune | Mob - 8055837949 <(805)%20583-7949>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Attachments:

  [image/png] image.png (11.6K, 3-image.png)
  download | view image

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgAdmin4 form control error icon position change
  In-Reply-To: <CA+OCxowkHXW0OTX18YmbVZnZcuLMpL4FTrwU2qAt+XcHAS4Eyw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox