public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Pravesh Sharma <[email protected]>
Cc: [email protected]
Subject: Re: Adding storage parameters on index
Date: Mon, 26 Jun 2023 11:23:23 +0530
Message-ID: <CAM9w-_kJ6ncwDtY4AWHFwWDjcC1iFAeFTLenKgdbO1xxcZCUqQ@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdsDiDQSaZRc=+XrL4sQi685jLNF0Ng_23B45x2O-4MMQ@mail.gmail.com>
References: <CA+36bxFeuGNZD6gcX+VE=R6V9cm95Q7P-OAi53Fg=sSrHCFrVg@mail.gmail.com>
<CANxoLDdsDiDQSaZRc=+XrL4sQi685jLNF0Ng_23B45x2O-4MMQ@mail.gmail.com>
Hi,
I would also suggest moving Columns and Include Columns to a separate tab -
Columns.
On Mon, Jun 26, 2023 at 11:19 AM Akshay Joshi <[email protected]>
wrote:
> Hi Pravesh
>
> On Fri, Jun 23, 2023 at 2:28 PM Pravesh Sharma <
> [email protected]> wrote:
>
>> Hi All,
>>
>> I am working on feature #6374
>> <https://github.com/pgadmin-org/pgadmin4/issues/6374; which is
>> adding storage parameters while creating an index. I have made changes in
>> the definition tab of create index to have all the required parameters.
>> Attached is the new design, please review it.
>>
>> I also have a few points which require suggestions.
>>
>> 1. Storage parameters are different for different access methods. If
>> an access method does not support a parameter we can either disable it or
>> hide it (I am thinking of hiding it based on the access method).
>>
>> Disable the controls.
>
>>
>> 1. There is a storage parameter named *buffering *which is by
>> default auto and takes on/off value. What type of control should I use for
>> it? Should it be a switch or a drop down with three options on, off and
>> auto, if we have a switch user won't be able to move to auto.
>>
>> It should be a drop-down with all three options.
>
>>
>> 1. There is a parameter *vacuum_cleanup_index_scale_factor *that was
>> added on PostgreSQL 11 but was removed on PostgreSQL 13, should we add this
>> too?
>>
>> No need to add the above parameter.
>
>>
>>
>> Thanks
>> Pravesh Sharma
>>
>> --
>>
>> <http://www.enterprisedb.com;
>>
>> Pravesh Sharma
>>
>> Software Engineer
>>
>> +91 9406461406
>>
>> www.enterprisedb.com
>>
>> Power to Postgres
>>
>> <https://www.linkedin.com/company/edbpostgres;
>> <https://twitter.com/edbpostgres?lang=en;
>> <https://www.facebook.com/EDBpostgres;
>> <https://www.instagram.com/EDBpostgres/;
>>
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Adding storage parameters on index
In-Reply-To: <CAM9w-_kJ6ncwDtY4AWHFwWDjcC1iFAeFTLenKgdbO1xxcZCUqQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox