public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][patch] Partition node related fixes
Date: Wed, 6 Oct 2021 17:32:10 +0530
Message-ID: <CAM9w-_kgxQmomoTcbmdLJ=F-qJ6GUF9L37X+XCQZx1yyEPjY_Q@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDeUvBsethaRNroJcHnpCLjhFtPt_dVfCM2u5DeQHDu=YA@mail.gmail.com>
References: <CAM9w-_nijDb7aVsamVnroUH9edmXaXi0En2Qtf8LOJD8=F-GUQ@mail.gmail.com>
<CANxoLDf6Wia8QL7x=xxVKfwfj6ip9b29o0qurF17NPutoBywjA@mail.gmail.com>
<CAM9w-_nykH8mrdGUa9MNrErZ=WVaNVE9WuzU55cxHY1bUSDtJQ@mail.gmail.com>
<CANxoLDeUvBsethaRNroJcHnpCLjhFtPt_dVfCM2u5DeQHDu=YA@mail.gmail.com>
Hi Hackers,
Following the chain, attached patch fixes indexes not loading in Primary
constraint and Unique const dialog for partition.
On Wed, Oct 6, 2021 at 5:00 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, the patch applied.
>
> On Wed, Oct 6, 2021 at 4:37 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> The nodes index, RLS policy, rules, triggers are failing to save for
>> partitions. Please review the attached patch to fix the issue.
>>
>> On Wed, Oct 6, 2021 at 2:54 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks, the patch applied.
>>>
>>> On Wed, Oct 6, 2021 at 12:25 PM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please review the attached patch which fixes:
>>>> 1. Unable to create trigger for partition table. Fixes #6867.
>>>> 2. Unable to create index, RLS policy, rules, triggers for partition.
>>>> Fixes #6868.
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>>>> <http://edbpostgres.com;
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>> <http://edbpostgres.com;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM6868.part3.patch (2.0K, 3-RM6868.part3.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js
index 742f767cf..d786993dc 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/primary_key.js
@@ -105,7 +105,7 @@ define('pgadmin.node.primary_key', [
spcname: ()=>getNodeListByName('tablespace', treeNodeInfo, itemNodeData, {}, (m)=>{
return (m.label != 'pg_global');
}),
- index: ()=>getNodeListByName('index', treeNodeInfo, itemNodeData),
+ index: ()=>getNodeListByName('index', treeNodeInfo, itemNodeData, {jumpAfterNode: 'schema'}),
}, treeNodeInfo);
},
// Define the model for index constraint node
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/unique_constraint.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/unique_constraint.js
index 7b2a8fe87..f24e06197 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/unique_constraint.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/index_constraint/static/js/unique_constraint.js
@@ -91,7 +91,7 @@ define('pgadmin.node.unique_constraint', [
spcname: ()=>getNodeListByName('tablespace', treeNodeInfo, itemNodeData, {}, (m)=>{
return (m.label != 'pg_global');
}),
- index: ()=>getNodeListByName('index', treeNodeInfo, itemNodeData),
+ index: ()=>getNodeListByName('index', treeNodeInfo, itemNodeData, {jumpAfterNode: 'schema'}),
}, treeNodeInfo);
},
});
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][patch] Partition node related fixes
In-Reply-To: <CAM9w-_kgxQmomoTcbmdLJ=F-qJ6GUF9L37X+XCQZx1yyEPjY_Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox