public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)
Date: Tue, 21 May 2019 17:42:09 +0530
Message-ID: <CAM9w-_khKH+yqMZA2AnJABEV1ntaXvMsYsAX_Jy30oSN=MnoDw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoz+C3JKXMu2u7taYGSsSVAEQh20w2mDyxqLSKbbFq=21g@mail.gmail.com>
References: <CAM9w-_=e8+iiEP0+pTv0htRHhUjupfK6N9dFS1wQNG6MBCq4Vw@mail.gmail.com>
	<CA+OCxoz+C3JKXMu2u7taYGSsSVAEQh20w2mDyxqLSKbbFq=21g@mail.gmail.com>

Hi,

On Tue, May 21, 2019 at 5:32 PM Dave Page <[email protected]> wrote:

> Hi
>
> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix the accessibility issue in query tool.
>>
>> The query tool can be completely restructured unlike previously where
>> query tool used to stick at top and other tabs in the bottom.
>> - I have added a new shortcut to switch between frames if in query tool
>> the tab positions are changed. On switching the frames, the frame will
>> blink to show it is focussed.
>> - In the frame, you can switch tab same as previous. The tabs in SQL
>> editor are cyclic now, which means if you execute shortcut to go right on
>> the last tab then it will cycle to first tab.
>> - I have also changed the default shortcut to switch between tabs from
>> Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we have in
>> browser tabs.
>> - Similar changes done for debugger also.
>>
>
> Shouldn't there be documentation changes to go with this?
>
Yes, definitely :P
Will send the updated patch.

>
> Otherwise, it seems to work :-)
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


-- 
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)
  In-Reply-To: <CAM9w-_khKH+yqMZA2AnJABEV1ntaXvMsYsAX_Jy30oSN=MnoDw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox