public inbox for [email protected]help / color / mirror / Atom feed
Regarding removal for wcDocker and replace it with rc-dock #6479 7+ messages / 3 participants [nested] [flat]
* Regarding removal for wcDocker and replace it with rc-dock #6479 @ 2023-08-10 11:25 Aditya Toshniwal <[email protected]> 0 siblings, 2 replies; 7+ messages in thread From: Aditya Toshniwal @ 2023-08-10 11:25 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, I am working on removing the jQuery based wcDocker with ReactJS based rc-dock. The new lib allows us to reset layout without reloading pgAdmin. The one thing it doesn't provide is adding a panel using tab bar context menu. I was able to add a custom context menu but only on the tabs and not on the complete tab bar. So my question is, do we need something to add a panel back or reset layout should be enough as we'll not reload pgAdmin? If yes, please suggest on how we can do it without using the context menu. One way is to have a menu with check menu items for each default panel. Attached is a screen recording to show the current behavior. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" Attachments: [video/quicktime] Screen Recording 2023-08-10 at 4.47.12 PM.mov (3.6M, 3-Screen%20Recording%202023-08-10%20at%204.47.12%20PM.mov) download ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Regarding removal for wcDocker and replace it with rc-dock #6479 @ 2023-08-10 11:35 Aditya Toshniwal <[email protected]> parent: Aditya Toshniwal <[email protected]> 1 sibling, 0 replies; 7+ messages in thread From: Aditya Toshniwal @ 2023-08-10 11:35 UTC (permalink / raw) To: pgadmin-hackers For direct viewing https://drive.google.com/file/d/1yvpA7fCtiHkKPbShnYJ1BQMnStKs9fKZ/view?usp=sharing On Thu, Aug 10, 2023 at 4:55 PM Aditya Toshniwal < [email protected]> wrote: > Hi Hackers, > > I am working on removing the jQuery based wcDocker with ReactJS based > rc-dock. > The new lib allows us to reset layout without reloading pgAdmin. The one > thing it doesn't provide is adding a panel using tab bar context menu. I > was able to add a custom context menu but only on the tabs and not on the > complete tab bar. > So my question is, do we need something to add a panel back or reset > layout should be enough as we'll not reload pgAdmin? > If yes, please suggest on how we can do it without using the context menu. > One way is to have a menu with check menu items for each default panel. > Attached is a screen recording to show the current behavior. > > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > <https://www.enterprisedb.com/; > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Regarding removal for wcDocker and replace it with rc-dock #6479 @ 2023-08-11 05:35 Nikhil Mohite <[email protected]> parent: Aditya Toshniwal <[email protected]> 1 sibling, 1 reply; 7+ messages in thread From: Nikhil Mohite @ 2023-08-11 05:35 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Hi Aditya, On Fri, Aug 11, 2023 at 12:56 AM Aditya Toshniwal < [email protected]> wrote: > Hi Hackers, > > I am working on removing the jQuery based wcDocker with ReactJS based > rc-dock. > The new lib allows us to reset layout without reloading pgAdmin. The one > thing it doesn't provide is adding a panel using tab bar context menu. I > was able to add a custom context menu but only on the tabs and not on the > complete tab bar. > So my question is, do we need something to add a panel back or reset > layout should be enough as we'll not reload pgAdmin? > If yes, please suggest on how we can do it without using the context menu. > One way is to have a menu with check menu items for each default panel. > Attached is a screen recording to show the current behavior. > > If we add a button in browser explorer(We can change the location of a button) and click on it will show a drop-down menu with a list of all closed tabs, and selecting it will open the selected tab on the right side. Something like this, click on the (+) plus button on Object Explorer and select the tab name from drop-down options. (I know there are Query Tool, Search, and PSQL Tool buttons already there we can change the location of the button) [image: image.png] > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > <https://www.enterprisedb.com/; > "Don't Complain about Heat, Plant a TREE" > Thanks, Nikhil Mohite Attachments: [image/png] image.png (449.0K, 3-image.png) download | view image ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Regarding removal for wcDocker and replace it with rc-dock #6479 @ 2023-08-11 06:40 Aditya Toshniwal <[email protected]> parent: Nikhil Mohite <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Aditya Toshniwal @ 2023-08-11 06:40 UTC (permalink / raw) To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers Hi Nikhil, On Fri, Aug 11, 2023 at 11:06 AM Nikhil Mohite < [email protected]> wrote: > Hi Aditya, > > On Fri, Aug 11, 2023 at 12:56 AM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Hackers, >> >> I am working on removing the jQuery based wcDocker with ReactJS based >> rc-dock. >> The new lib allows us to reset layout without reloading pgAdmin. The one >> thing it doesn't provide is adding a panel using tab bar context menu. I >> was able to add a custom context menu but only on the tabs and not on the >> complete tab bar. >> So my question is, do we need something to add a panel back or reset >> layout should be enough as we'll not reload pgAdmin? >> If yes, please suggest on how we can do it without using the context >> menu. One way is to have a menu with check menu items for each default >> panel. >> Attached is a screen recording to show the current behavior. >> >> If we add a button in browser explorer(We can change the location of a > button) and click on it will show a drop-down menu with a list of all > closed tabs, and selecting it will open the selected tab on the right side. > Something like this, click on the (+) plus button on Object Explorer and > select the tab name from drop-down options. (I know there are Query Tool, > Search, and PSQL Tool buttons already there we can change the location of > the button) > I think we can do that, but on the main panel and not on object explorer and with some relevant icon. Any other suggestions/ideas? > [image: image.png] > >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* >> <https://www.enterprisedb.com/; >> "Don't Complain about Heat, Plant a TREE" >> > > Thanks, > Nikhil Mohite > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] image.png (449.0K, 3-image.png) download | view image ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Regarding removal for wcDocker and replace it with rc-dock #6479 @ 2023-08-11 08:35 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Dave Page @ 2023-08-11 08:35 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Nikhil Mohite <[email protected]>; pgadmin-hackers On Fri, 11 Aug 2023 at 07:42, Aditya Toshniwal < [email protected]> wrote: > Hi Nikhil, > > On Fri, Aug 11, 2023 at 11:06 AM Nikhil Mohite < > [email protected]> wrote: > >> Hi Aditya, >> >> On Fri, Aug 11, 2023 at 12:56 AM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> I am working on removing the jQuery based wcDocker with ReactJS based >>> rc-dock. >>> The new lib allows us to reset layout without reloading pgAdmin. The one >>> thing it doesn't provide is adding a panel using tab bar context menu. I >>> was able to add a custom context menu but only on the tabs and not on the >>> complete tab bar. >>> So my question is, do we need something to add a panel back or reset >>> layout should be enough as we'll not reload pgAdmin? >>> If yes, please suggest on how we can do it without using the context >>> menu. One way is to have a menu with check menu items for each default >>> panel. >>> Attached is a screen recording to show the current behavior. >>> >>> If we add a button in browser explorer(We can change the location of a >> button) and click on it will show a drop-down menu with a list of all >> closed tabs, and selecting it will open the selected tab on the right side. >> Something like this, click on the (+) plus button on Object Explorer and >> select the tab name from drop-down options. (I know there are Query Tool, >> Search, and PSQL Tool buttons already there we can change the location of >> the button) >> > I think we can do that, but on the main panel and not on object explorer > and with some relevant icon. > Any other suggestions/ideas? > I'm surprised a man of your talents can't catch the right-click - any particular reason it's giving you problems? Assuming it really is that hard, can we do something like Chrome (similar to Nikhil's suggestion)? [image: Screenshot 2023-08-11 at 09.33.53.png] > [image: image.png] >> >>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* >>> <https://www.enterprisedb.com/; >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> Thanks, >> Nikhil Mohite >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* > <https://www.enterprisedb.com/; > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com Attachments: [image/png] image.png (449.0K, 3-image.png) download | view image [image/png] Screenshot 2023-08-11 at 09.33.53.png (16.9K, 4-Screenshot%202023-08-11%20at%2009.33.53.png) download | view image ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Regarding removal for wcDocker and replace it with rc-dock #6479 @ 2023-08-11 08:47 Aditya Toshniwal <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Aditya Toshniwal @ 2023-08-11 08:47 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Nikhil Mohite <[email protected]>; pgadmin-hackers Hi Dave, On Fri, Aug 11, 2023 at 2:05 PM Dave Page <[email protected]> wrote: > > > On Fri, 11 Aug 2023 at 07:42, Aditya Toshniwal < > [email protected]> wrote: > >> Hi Nikhil, >> >> On Fri, Aug 11, 2023 at 11:06 AM Nikhil Mohite < >> [email protected]> wrote: >> >>> Hi Aditya, >>> >>> On Fri, Aug 11, 2023 at 12:56 AM Aditya Toshniwal < >>> [email protected]> wrote: >>> >>>> Hi Hackers, >>>> >>>> I am working on removing the jQuery based wcDocker with ReactJS based >>>> rc-dock. >>>> The new lib allows us to reset layout without reloading pgAdmin. The >>>> one thing it doesn't provide is adding a panel using tab bar context menu. >>>> I was able to add a custom context menu but only on the tabs and not on the >>>> complete tab bar. >>>> So my question is, do we need something to add a panel back or reset >>>> layout should be enough as we'll not reload pgAdmin? >>>> If yes, please suggest on how we can do it without using the context >>>> menu. One way is to have a menu with check menu items for each default >>>> panel. >>>> Attached is a screen recording to show the current behavior. >>>> >>>> If we add a button in browser explorer(We can change the location of a >>> button) and click on it will show a drop-down menu with a list of all >>> closed tabs, and selecting it will open the selected tab on the right side. >>> Something like this, click on the (+) plus button on Object Explorer and >>> select the tab name from drop-down options. (I know there are Query Tool, >>> Search, and PSQL Tool buttons already there we can change the location of >>> the button) >>> >> I think we can do that, but on the main panel and not on object explorer >> and with some relevant icon. >> Any other suggestions/ideas? >> > > I'm surprised a man of your talents can't catch the right-click - any > particular reason it's giving you problems? > Thank you for your appreciation. The problem here is rc-dock doesn't provide any API to allow the onContextMenu event on the tab bar. I could hack and add using JS native querySelector and addListener, but that is error prone and not the right way to do it in React. I have used a custom component for tab title, so I was able to capture the event on the tabs. > > Assuming it really is that hard, can we do something like Chrome (similar > to Nikhil's suggestion)? > > [image: Screenshot 2023-08-11 at 09.33.53.png] > Chrome has only one type of tab, but pgAdmin has many. I am thinking of something similar to PyCharm. [image: image.png] > > >> [image: image.png] >>> >>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* >>>> <https://www.enterprisedb.com/; >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> Thanks, >>> Nikhil Mohite >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* >> <https://www.enterprisedb.com/; >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] image.png (449.0K, 3-image.png) download | view image [image/png] Screenshot 2023-08-11 at 09.33.53.png (16.9K, 4-Screenshot%202023-08-11%20at%2009.33.53.png) download | view image [image/png] image.png (128.1K, 5-image.png) download | view image ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Regarding removal for wcDocker and replace it with rc-dock #6479 @ 2023-08-11 08:51 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 0 replies; 7+ messages in thread From: Dave Page @ 2023-08-11 08:51 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Nikhil Mohite <[email protected]>; pgadmin-hackers On Fri, 11 Aug 2023 at 09:48, Aditya Toshniwal < [email protected]> wrote: > Hi Dave, > > I think we can do that, but on the main panel and not on object explorer >>> and with some relevant icon. >>> Any other suggestions/ideas? >>> >> >> I'm surprised a man of your talents can't catch the right-click - any >> particular reason it's giving you problems? >> > Thank you for your appreciation. The problem here is rc-dock doesn't > provide any API to allow the onContextMenu event on the tab bar. I could > hack and add using JS native querySelector and addListener, but that is > error prone and not the right way to do it in React. I have used a custom > component for tab title, so I was able to capture the event on the tabs. > >> >> Assuming it really is that hard, can we do something like Chrome (similar >> to Nikhil's suggestion)? >> >> [image: Screenshot 2023-08-11 at 09.33.53.png] >> > Chrome has only one type of tab, but pgAdmin has many. I am thinking of > something similar to PyCharm. > [image: image.png] > That works for me. -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com Attachments: [image/png] Screenshot 2023-08-11 at 09.33.53.png (16.9K, 3-Screenshot%202023-08-11%20at%2009.33.53.png) download | view image [image/png] image.png (128.1K, 4-image.png) download | view image ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2023-08-11 08:51 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-08-10 11:25 Regarding removal for wcDocker and replace it with rc-dock #6479 Aditya Toshniwal <[email protected]> 2023-08-10 11:35 ` Aditya Toshniwal <[email protected]> 2023-08-11 05:35 ` Nikhil Mohite <[email protected]> 2023-08-11 06:40 ` Aditya Toshniwal <[email protected]> 2023-08-11 08:35 ` Dave Page <[email protected]> 2023-08-11 08:47 ` Aditya Toshniwal <[email protected]> 2023-08-11 08:51 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox