public inbox for [email protected]  

help / color / mirror / Atom feed

From: Aditya Toshniwal <[email protected]>
To: Pravesh Sharma <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Dave Page <[email protected]>
Subject: Re: Require suggestions on feature 6794
Date: Tue, 26 Nov 2024 16:59:47 +0530
Message-ID: <CAM9w-_kvjS_g1ZX5So=zMo-eJ=8H4_Ws=mfDEcDR92ftG4V3UA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoym5MAXyf-BBf_skn=DK2LkZcEr8GXpSQTqSsvWs1DgcQ@mail.gmail.com>
References: <CA+36bxFXWcbCtjnH-TT9kTkw9uq-XdAQkN1joXbPyDO8kQQg1Q@mail.gmail.com>
	<CA+OCxoym5MAXyf-BBf_skn=DK2LkZcEr8GXpSQTqSsvWs1DgcQ@mail.gmail.com>

Hi Pravesh,

In addition to that, why do we need env vars at all? We can simply pass
them as arguments to passexec script. It's up to the users to use it or
ignore it.

On Tue, Nov 26, 2024 at 4:54 PM Dave Page <[email protected]> wrote:

> Hi
>
> On Tue, 26 Nov 2024 at 10:55, Pravesh Sharma <
> [email protected]> wrote:
>
>> Hi Dave/Team
>>
>> I have started working on feature #6794
>> <https://github.com/pgadmin-org/pgadmin4/issues/6794;. The user wants to
>> pass connection information, such as host, port, and username, to the
>> passexec command without hardcoding these values. I plan to implement it as
>> follows: The user will set environment variables for the host, port, and
>> username, and before running the passexec command, we will replace the
>> corresponding values with the environment variables.
>>
>>
>> Please share your suggestions or feedback on the approach I am proposing.
>>
>
> I'm not sure why the user would need to set environment variables -
> wouldn't pgAdmin just set them in the environment of the passexec
> process, based on the server definition?
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> pgEdge: https://www.pgedge.com
>
>

-- 
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Require suggestions on feature 6794
  In-Reply-To: <CAM9w-_kvjS_g1ZX5So=zMo-eJ=8H4_Ws=mfDEcDR92ftG4V3UA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox