public inbox for [email protected]help / color / mirror / Atom feed
Require suggestions on feature 6794 4+ messages / 3 participants [nested] [flat]
* Require suggestions on feature 6794 @ 2024-11-26 10:55 Pravesh Sharma <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Pravesh Sharma @ 2024-11-26 10:55 UTC (permalink / raw) To: pgadmin-hackers; +Cc: Dave Page <[email protected]> Hi Dave/Team I have started working on feature #6794 <https://github.com/pgadmin-org/pgadmin4/issues/6794;. The user wants to pass connection information, such as host, port, and username, to the passexec command without hardcoding these values. I plan to implement it as follows: The user will set environment variables for the host, port, and username, and before running the passexec command, we will replace the corresponding values with the environment variables. Please share your suggestions or feedback on the approach I am proposing. Thanks, Pravesh -- Pravesh Sharma Senior SDE +91 9406461406 enterprisedb.com ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Require suggestions on feature 6794 @ 2024-11-26 11:24 Dave Page <[email protected]> parent: Pravesh Sharma <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Dave Page @ 2024-11-26 11:24 UTC (permalink / raw) To: Pravesh Sharma <[email protected]>; +Cc: pgadmin-hackers Hi On Tue, 26 Nov 2024 at 10:55, Pravesh Sharma < [email protected]> wrote: > Hi Dave/Team > > I have started working on feature #6794 > <https://github.com/pgadmin-org/pgadmin4/issues/6794;. The user wants to > pass connection information, such as host, port, and username, to the > passexec command without hardcoding these values. I plan to implement it as > follows: The user will set environment variables for the host, port, and > username, and before running the passexec command, we will replace the > corresponding values with the environment variables. > > > Please share your suggestions or feedback on the approach I am proposing. > I'm not sure why the user would need to set environment variables - wouldn't pgAdmin just set them in the environment of the passexec process, based on the server definition? -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org pgEdge: https://www.pgedge.com ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Require suggestions on feature 6794 @ 2024-11-26 11:29 Aditya Toshniwal <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2024-11-26 11:29 UTC (permalink / raw) To: Pravesh Sharma <[email protected]>; +Cc: pgadmin-hackers; Dave Page <[email protected]> Hi Pravesh, In addition to that, why do we need env vars at all? We can simply pass them as arguments to passexec script. It's up to the users to use it or ignore it. On Tue, Nov 26, 2024 at 4:54 PM Dave Page <[email protected]> wrote: > Hi > > On Tue, 26 Nov 2024 at 10:55, Pravesh Sharma < > [email protected]> wrote: > >> Hi Dave/Team >> >> I have started working on feature #6794 >> <https://github.com/pgadmin-org/pgadmin4/issues/6794;. The user wants to >> pass connection information, such as host, port, and username, to the >> passexec command without hardcoding these values. I plan to implement it as >> follows: The user will set environment variables for the host, port, and >> username, and before running the passexec command, we will replace the >> corresponding values with the environment variables. >> >> >> Please share your suggestions or feedback on the approach I am proposing. >> > > I'm not sure why the user would need to set environment variables - > wouldn't pgAdmin just set them in the environment of the passexec > process, based on the server definition? > > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > pgEdge: https://www.pgedge.com > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Require suggestions on feature 6794 @ 2024-11-26 11:33 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Dave Page @ 2024-11-26 11:33 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Pravesh Sharma <[email protected]>; pgadmin-hackers On Tue, 26 Nov 2024 at 11:30, Aditya Toshniwal < [email protected]> wrote: > Hi Pravesh, > > In addition to that, why do we need env vars at all? We can simply pass > them as arguments to passexec script. It's up to the users to use it or > ignore it. > Or do some string substitution in the command, e.g. /path/to/passexec.sh $HOST$ $PORT$ or similar, so the user has even more flexibility. I know that is done in PEM in a few places, possibly in pgAdmin too, though I don't recall offhand (if it is, we should be consistent on how the parameters are notated). -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org pgEdge: https://www.pgedge.com ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-11-26 11:33 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-11-26 10:55 Require suggestions on feature 6794 Pravesh Sharma <[email protected]> 2024-11-26 11:24 ` Dave Page <[email protected]> 2024-11-26 11:29 ` Aditya Toshniwal <[email protected]> 2024-11-26 11:33 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox