public inbox for [email protected]help / color / mirror / Atom feed
Disabled or Not applicable Tabs design 12+ messages / 4 participants [nested] [flat]
* Disabled or Not applicable Tabs design @ 2025-02-21 09:37 Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 12+ messages in thread From: Aditya Toshniwal @ 2025-02-21 09:37 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, I've been working on a new feature to restore a plain SQL using the pgAdmin restore dialog. Internally, it will select pg_restore or psql based on the format. Now, when restoring plain format the tabs like Data Options, Query Options are not applicable. So instead of going and disabling all the fields under these tabs, I think we can simply disable the complete tab. I've come up with the following UI design for the disabled tabs. The tabs will enable/disable based on the format selected. Please share your feedback on this. [image: image.png] -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-21 09:50 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 2 replies; 12+ messages in thread From: Dave Page @ 2025-02-21 09:50 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < [email protected]> wrote: > Hi Hackers, > > I've been working on a new feature to restore a plain SQL using the > pgAdmin restore dialog. Internally, it will select pg_restore or psql based > on the format. > > Now, when restoring plain format the tabs like Data Options, Query Options > are not applicable. So instead of going and disabling all the fields under > these tabs, I think we can simply disable the complete tab. > > I've come up with the following UI design for the disabled tabs. The tabs > will enable/disable based on the format selected. > > Please share your feedback on this. > > > [image: image.png] > Normally when something is disabled, it is simply greyed out and made to not respond to input. Why not do the same here instead of designing a new way of indicating disabled state? -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org pgEdge: https://www.pgedge.com Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-21 10:11 Zaid Shabbir <[email protected]> parent: Dave Page <[email protected]> 1 sibling, 0 replies; 12+ messages in thread From: Zaid Shabbir @ 2025-02-21 10:11 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; pgadmin-hackers Hello, Comments inline.. On Fri, 21 Feb 2025 at 2:51 PM, Dave Page <[email protected]> wrote: > > > On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < > [email protected]> wrote: > >> Hi Hackers, >> >> I've been working on a new feature to restore a plain SQL using the >> pgAdmin restore dialog. Internally, it will select pg_restore or psql based >> on the format. >> >> Now, when restoring plain format the tabs like Data Options, >> Query Options are not applicable. So instead of going and disabling all the >> fields under these tabs, I think we can simply disable the complete tab. >> >> I've come up with the following UI design for the disabled tabs. The tabs >> will enable/disable based on the format selected. >> >> Please share your feedback on this. >> >> >> [image: image.png] >> > > Normally when something is disabled, it is simply greyed out and made to > not respond to input. Why not do the same here instead of designing a new > way of indicating disabled state? > *Agreed with Dave. We need to follow the GUI standards while designing, so that it’s more usable.* *With the disabled gray label, we might change the disabled tab colour to dark gray, and on pointer move event, we can show the reason of disablement.* *The use of semiotics on tabs may complex or provide a heavy look and feel.* > > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > pgEdge: https://www.pgedge.com > > Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-21 10:26 Aditya Toshniwal <[email protected]> parent: Dave Page <[email protected]> 1 sibling, 1 reply; 12+ messages in thread From: Aditya Toshniwal @ 2025-02-21 10:26 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Hi Dave, On Fri, Feb 21, 2025 at 3:21 PM Dave Page <[email protected]> wrote: > > > On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < > [email protected]> wrote: > >> Hi Hackers, >> >> I've been working on a new feature to restore a plain SQL using the >> pgAdmin restore dialog. Internally, it will select pg_restore or psql based >> on the format. >> >> Now, when restoring plain format the tabs like Data Options, >> Query Options are not applicable. So instead of going and disabling all the >> fields under these tabs, I think we can simply disable the complete tab. >> >> I've come up with the following UI design for the disabled tabs. The tabs >> will enable/disable based on the format selected. >> >> Please share your feedback on this. >> >> >> [image: image.png] >> > > Normally when something is disabled, it is simply greyed out and made to > not respond to input. Why not do the same here instead of designing a new > way of indicating disabled state? > I thought of adding an icon for better accessibility. Greying is pretty straightforward. > > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > pgEdge: https://www.pgedge.com > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-21 10:31 Aditya Toshniwal <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 12+ messages in thread From: Aditya Toshniwal @ 2025-02-21 10:31 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Updated design: [image: image.png] On Fri, Feb 21, 2025 at 3:56 PM Aditya Toshniwal < [email protected]> wrote: > Hi Dave, > > On Fri, Feb 21, 2025 at 3:21 PM Dave Page <[email protected]> wrote: > >> >> >> On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> I've been working on a new feature to restore a plain SQL using the >>> pgAdmin restore dialog. Internally, it will select pg_restore or psql based >>> on the format. >>> >>> Now, when restoring plain format the tabs like Data Options, >>> Query Options are not applicable. So instead of going and disabling all the >>> fields under these tabs, I think we can simply disable the complete tab. >>> >>> I've come up with the following UI design for the disabled tabs. The >>> tabs will enable/disable based on the format selected. >>> >>> Please share your feedback on this. >>> >>> >>> [image: image.png] >>> >> >> Normally when something is disabled, it is simply greyed out and made to >> not respond to input. Why not do the same here instead of designing a new >> way of indicating disabled state? >> > I thought of adding an icon for better accessibility. Greying is pretty > straightforward. > >> >> -- >> Dave Page >> pgAdmin: https://www.pgadmin.org >> PostgreSQL: https://www.postgresql.org >> pgEdge: https://www.pgedge.com >> >> > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* > <https://www.enterprisedb.com/; > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image [image/png] image.png (82.5K, 4-image.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-21 10:55 Zaid Shabbir <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 12+ messages in thread From: Zaid Shabbir @ 2025-02-21 10:55 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Hello Aditya, The above design looks good to me. We could improve visibility by adding vertical and horizontal lines in a combination of blue, gray, and black. Blue represents the current active tab, gray indicates a disabled tab, and black signifies available clickable options. e.g. [image: Sample.png] Regards, Zaid Shabbir On Fri, Feb 21, 2025 at 3:32 PM Aditya Toshniwal < [email protected]> wrote: > Hi Hackers, > > Updated design: > > [image: image.png] > > On Fri, Feb 21, 2025 at 3:56 PM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Dave, >> >> On Fri, Feb 21, 2025 at 3:21 PM Dave Page <[email protected]> wrote: >> >>> >>> >>> On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < >>> [email protected]> wrote: >>> >>>> Hi Hackers, >>>> >>>> I've been working on a new feature to restore a plain SQL using the >>>> pgAdmin restore dialog. Internally, it will select pg_restore or psql based >>>> on the format. >>>> >>>> Now, when restoring plain format the tabs like Data Options, >>>> Query Options are not applicable. So instead of going and disabling all the >>>> fields under these tabs, I think we can simply disable the complete tab. >>>> >>>> I've come up with the following UI design for the disabled tabs. The >>>> tabs will enable/disable based on the format selected. >>>> >>>> Please share your feedback on this. >>>> >>>> >>>> [image: image.png] >>>> >>> >>> Normally when something is disabled, it is simply greyed out and made to >>> not respond to input. Why not do the same here instead of designing a new >>> way of indicating disabled state? >>> >> I thought of adding an icon for better accessibility. Greying is pretty >> straightforward. >> >>> >>> -- >>> Dave Page >>> pgAdmin: https://www.pgadmin.org >>> PostgreSQL: https://www.postgresql.org >>> pgEdge: https://www.pgedge.com >>> >>> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >> <https://www.enterprisedb.com/; >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* > <https://www.enterprisedb.com/; > "Don't Complain about Heat, Plant a TREE" > Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image [image/png] image.png (82.5K, 4-image.png) download | view image [image/png] Sample.png (19.9K, 5-Sample.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-21 10:58 Aditya Toshniwal <[email protected]> parent: Zaid Shabbir <[email protected]> 0 siblings, 1 reply; 12+ messages in thread From: Aditya Toshniwal @ 2025-02-21 10:58 UTC (permalink / raw) To: Zaid Shabbir <[email protected]>; +Cc: pgadmin-hackers Hi Zaid, On Fri, Feb 21, 2025 at 4:26 PM Zaid Shabbir <[email protected]> wrote: > Hello Aditya, > > The above design looks good to me. We could improve visibility by adding > vertical and horizontal lines in a combination of blue, gray, and black. > Blue represents the current active tab, gray indicates a disabled tab, and > black signifies available clickable options. > > e.g. > > [image: Sample.png] > That doesn't match the pgAdmin design. The colors which you mentioned are already being used. > > Regards, > > Zaid Shabbir > > On Fri, Feb 21, 2025 at 3:32 PM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Hackers, >> >> Updated design: >> >> [image: image.png] >> >> On Fri, Feb 21, 2025 at 3:56 PM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi Dave, >>> >>> On Fri, Feb 21, 2025 at 3:21 PM Dave Page <[email protected]> wrote: >>> >>>> >>>> >>>> On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < >>>> [email protected]> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> I've been working on a new feature to restore a plain SQL using the >>>>> pgAdmin restore dialog. Internally, it will select pg_restore or psql based >>>>> on the format. >>>>> >>>>> Now, when restoring plain format the tabs like Data Options, >>>>> Query Options are not applicable. So instead of going and disabling all the >>>>> fields under these tabs, I think we can simply disable the complete tab. >>>>> >>>>> I've come up with the following UI design for the disabled tabs. The >>>>> tabs will enable/disable based on the format selected. >>>>> >>>>> Please share your feedback on this. >>>>> >>>>> >>>>> [image: image.png] >>>>> >>>> >>>> Normally when something is disabled, it is simply greyed out and made >>>> to not respond to input. Why not do the same here instead of designing a >>>> new way of indicating disabled state? >>>> >>> I thought of adding an icon for better accessibility. Greying is pretty >>> straightforward. >>> >>>> >>>> -- >>>> Dave Page >>>> pgAdmin: https://www.pgadmin.org >>>> PostgreSQL: https://www.postgresql.org >>>> pgEdge: https://www.pgedge.com >>>> >>>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>> <https://www.enterprisedb.com/; >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >> <https://www.enterprisedb.com/; >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image [image/png] image.png (82.5K, 4-image.png) download | view image [image/png] Sample.png (19.9K, 5-Sample.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-21 11:33 Zaid Shabbir <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 12+ messages in thread From: Zaid Shabbir @ 2025-02-21 11:33 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Hello, Some other samples for the tabular window. [image: Screenshot 2025-02-21 at 4.29.30 PM.png] Aditiya it's just a suggestion, you can use the most suitable layout and colors. Regards, Zaid Shabbir On Fri, Feb 21, 2025 at 3:59 PM Aditya Toshniwal < [email protected]> wrote: > Hi Zaid, > > On Fri, Feb 21, 2025 at 4:26 PM Zaid Shabbir <[email protected]> > wrote: > >> Hello Aditya, >> >> The above design looks good to me. We could improve visibility by adding >> vertical and horizontal lines in a combination of blue, gray, and black. >> Blue represents the current active tab, gray indicates a disabled tab, and >> black signifies available clickable options. >> >> e.g. >> >> [image: Sample.png] >> > That doesn't match the pgAdmin design. The colors which you mentioned are > already being used. > >> >> Regards, >> >> Zaid Shabbir >> >> On Fri, Feb 21, 2025 at 3:32 PM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> Updated design: >>> >>> [image: image.png] >>> >>> On Fri, Feb 21, 2025 at 3:56 PM Aditya Toshniwal < >>> [email protected]> wrote: >>> >>>> Hi Dave, >>>> >>>> On Fri, Feb 21, 2025 at 3:21 PM Dave Page <[email protected]> wrote: >>>> >>>>> >>>>> >>>>> On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> I've been working on a new feature to restore a plain SQL using the >>>>>> pgAdmin restore dialog. Internally, it will select pg_restore or psql based >>>>>> on the format. >>>>>> >>>>>> Now, when restoring plain format the tabs like Data Options, >>>>>> Query Options are not applicable. So instead of going and disabling all the >>>>>> fields under these tabs, I think we can simply disable the complete tab. >>>>>> >>>>>> I've come up with the following UI design for the disabled tabs. The >>>>>> tabs will enable/disable based on the format selected. >>>>>> >>>>>> Please share your feedback on this. >>>>>> >>>>>> >>>>>> [image: image.png] >>>>>> >>>>> >>>>> Normally when something is disabled, it is simply greyed out and made >>>>> to not respond to input. Why not do the same here instead of designing a >>>>> new way of indicating disabled state? >>>>> >>>> I thought of adding an icon for better accessibility. Greying is >>>> pretty straightforward. >>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> pgAdmin: https://www.pgadmin.org >>>>> PostgreSQL: https://www.postgresql.org >>>>> pgEdge: https://www.pgedge.com >>>>> >>>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>> <https://www.enterprisedb.com/; >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>> <https://www.enterprisedb.com/; >>> "Don't Complain about Heat, Plant a TREE" >>> >> > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* > <https://www.enterprisedb.com/; > "Don't Complain about Heat, Plant a TREE" > Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image [image/png] image.png (82.5K, 4-image.png) download | view image [image/png] Sample.png (19.9K, 5-Sample.png) download | view image [image/png] Screenshot 2025-02-21 at 4.29.30 PM.png (105.1K, 6-Screenshot%202025-02-21%20at%204.29.30%20PM.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-21 11:40 Aditya Toshniwal <[email protected]> parent: Zaid Shabbir <[email protected]> 0 siblings, 1 reply; 12+ messages in thread From: Aditya Toshniwal @ 2025-02-21 11:40 UTC (permalink / raw) To: Zaid Shabbir <[email protected]>; +Cc: pgadmin-hackers Hi Zaid, Changing tab design will need changes in the complete application. It also needs to be discussed with everyone before changing it. Anyway, it should not be part of the task I'm working on. You can open a separate thread for discussions. On Fri, Feb 21, 2025 at 5:03 PM Zaid Shabbir <[email protected]> wrote: > Hello, > > Some other samples for the tabular window. > > [image: Screenshot 2025-02-21 at 4.29.30 PM.png] > > Aditiya it's just a suggestion, you can use the most suitable layout and > colors. > > Regards, > Zaid Shabbir > > > > On Fri, Feb 21, 2025 at 3:59 PM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Zaid, >> >> On Fri, Feb 21, 2025 at 4:26 PM Zaid Shabbir <[email protected]> >> wrote: >> >>> Hello Aditya, >>> >>> The above design looks good to me. We could improve visibility by adding >>> vertical and horizontal lines in a combination of blue, gray, and black. >>> Blue represents the current active tab, gray indicates a disabled tab, and >>> black signifies available clickable options. >>> >>> e.g. >>> >>> [image: Sample.png] >>> >> That doesn't match the pgAdmin design. The colors which you mentioned are >> already being used. >> >>> >>> Regards, >>> >>> Zaid Shabbir >>> >>> On Fri, Feb 21, 2025 at 3:32 PM Aditya Toshniwal < >>> [email protected]> wrote: >>> >>>> Hi Hackers, >>>> >>>> Updated design: >>>> >>>> [image: image.png] >>>> >>>> On Fri, Feb 21, 2025 at 3:56 PM Aditya Toshniwal < >>>> [email protected]> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> On Fri, Feb 21, 2025 at 3:21 PM Dave Page <[email protected]> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> I've been working on a new feature to restore a plain SQL using the >>>>>>> pgAdmin restore dialog. Internally, it will select pg_restore or psql based >>>>>>> on the format. >>>>>>> >>>>>>> Now, when restoring plain format the tabs like Data Options, >>>>>>> Query Options are not applicable. So instead of going and disabling all the >>>>>>> fields under these tabs, I think we can simply disable the complete tab. >>>>>>> >>>>>>> I've come up with the following UI design for the disabled tabs. The >>>>>>> tabs will enable/disable based on the format selected. >>>>>>> >>>>>>> Please share your feedback on this. >>>>>>> >>>>>>> >>>>>>> [image: image.png] >>>>>>> >>>>>> >>>>>> Normally when something is disabled, it is simply greyed out and made >>>>>> to not respond to input. Why not do the same here instead of designing a >>>>>> new way of indicating disabled state? >>>>>> >>>>> I thought of adding an icon for better accessibility. Greying is >>>>> pretty straightforward. >>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> pgAdmin: https://www.pgadmin.org >>>>>> PostgreSQL: https://www.postgresql.org >>>>>> pgEdge: https://www.pgedge.com >>>>>> >>>>>> >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>>> <https://www.enterprisedb.com/; >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>> <https://www.enterprisedb.com/; >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >> <https://www.enterprisedb.com/; >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image [image/png] image.png (82.5K, 4-image.png) download | view image [image/png] Sample.png (19.9K, 5-Sample.png) download | view image [image/png] Screenshot 2025-02-21 at 4.29.30 PM.png (105.1K, 6-Screenshot%202025-02-21%20at%204.29.30%20PM.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-21 11:47 Dave Page <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 2 replies; 12+ messages in thread From: Dave Page @ 2025-02-21 11:47 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Zaid Shabbir <[email protected]>; pgadmin-hackers On Fri, 21 Feb 2025 at 11:40, Aditya Toshniwal < [email protected]> wrote: > Hi Zaid, > > Changing tab design will need changes in the complete application. It also > needs to be discussed with everyone before changing it. > Anyway, it should not be part of the task I'm working on. You can open a > separate thread for discussions. > Agreed. I do think the greyed option is the best way forward, even if there are potential improvements we could make to the design app-wide. > > On Fri, Feb 21, 2025 at 5:03 PM Zaid Shabbir <[email protected]> > wrote: > >> Hello, >> >> Some other samples for the tabular window. >> >> [image: Screenshot 2025-02-21 at 4.29.30 PM.png] >> >> Aditiya it's just a suggestion, you can use the most suitable layout and >> colors. >> >> Regards, >> Zaid Shabbir >> >> >> >> On Fri, Feb 21, 2025 at 3:59 PM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi Zaid, >>> >>> On Fri, Feb 21, 2025 at 4:26 PM Zaid Shabbir <[email protected]> >>> wrote: >>> >>>> Hello Aditya, >>>> >>>> The above design looks good to me. We could improve visibility by >>>> adding vertical and horizontal lines in a combination of blue, gray, and >>>> black. Blue represents the current active tab, gray indicates a disabled >>>> tab, and black signifies available clickable options. >>>> >>>> e.g. >>>> >>>> [image: Sample.png] >>>> >>> That doesn't match the pgAdmin design. The colors which you mentioned >>> are already being used. >>> >>>> >>>> Regards, >>>> >>>> Zaid Shabbir >>>> >>>> On Fri, Feb 21, 2025 at 3:32 PM Aditya Toshniwal < >>>> [email protected]> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Updated design: >>>>> >>>>> [image: image.png] >>>>> >>>>> On Fri, Feb 21, 2025 at 3:56 PM Aditya Toshniwal < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> On Fri, Feb 21, 2025 at 3:21 PM Dave Page <[email protected]> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi Hackers, >>>>>>>> >>>>>>>> I've been working on a new feature to restore a plain SQL using the >>>>>>>> pgAdmin restore dialog. Internally, it will select pg_restore or psql based >>>>>>>> on the format. >>>>>>>> >>>>>>>> Now, when restoring plain format the tabs like Data Options, >>>>>>>> Query Options are not applicable. So instead of going and disabling all the >>>>>>>> fields under these tabs, I think we can simply disable the complete tab. >>>>>>>> >>>>>>>> I've come up with the following UI design for the disabled tabs. >>>>>>>> The tabs will enable/disable based on the format selected. >>>>>>>> >>>>>>>> Please share your feedback on this. >>>>>>>> >>>>>>>> >>>>>>>> [image: image.png] >>>>>>>> >>>>>>> >>>>>>> Normally when something is disabled, it is simply greyed out and >>>>>>> made to not respond to input. Why not do the same here instead of designing >>>>>>> a new way of indicating disabled state? >>>>>>> >>>>>> I thought of adding an icon for better accessibility. Greying is >>>>>> pretty straightforward. >>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>> pgEdge: https://www.pgedge.com >>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> Thanks, >>>>>> Aditya Toshniwal >>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>>>> <https://www.enterprisedb.com/; >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>>> <https://www.enterprisedb.com/; >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>> <https://www.enterprisedb.com/; >>> "Don't Complain about Heat, Plant a TREE" >>> >> > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* > <https://www.enterprisedb.com/; > "Don't Complain about Heat, Plant a TREE" > -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org pgEdge: https://www.pgedge.com Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image [image/png] image.png (82.5K, 4-image.png) download | view image [image/png] Sample.png (19.9K, 5-Sample.png) download | view image [image/png] Screenshot 2025-02-21 at 4.29.30 PM.png (105.1K, 6-Screenshot%202025-02-21%20at%204.29.30%20PM.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-22 11:18 Usman Khan <[email protected]> parent: Dave Page <[email protected]> 1 sibling, 0 replies; 12+ messages in thread From: Usman Khan @ 2025-02-22 11:18 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; Zaid Shabbir <[email protected]>; pgadmin-hackers On Fri, Feb 21, 2025 at 4:47 PM Dave Page <[email protected]> wrote: > > > On Fri, 21 Feb 2025 at 11:40, Aditya Toshniwal < > [email protected]> wrote: > >> Hi Zaid, >> >> Changing tab design will need changes in the complete application. It >> also needs to be discussed with everyone before changing it. >> Anyway, it should not be part of the task I'm working on. You can open a >> separate thread for discussions. >> > > Agreed. > > I do think the greyed option is the best way forward, even if there are > potential improvements we could make to the design app-wide. > > >> >> On Fri, Feb 21, 2025 at 5:03 PM Zaid Shabbir <[email protected]> >> wrote: >> >>> Hello, >>> >>> Some other samples for the tabular window. >>> >>> [image: Screenshot 2025-02-21 at 4.29.30 PM.png] >>> >>> Aditiya it's just a suggestion, you can use the most suitable layout and >>> colors. >>> >>> Regards, >>> Zaid Shabbir >>> >>> >>> >>> On Fri, Feb 21, 2025 at 3:59 PM Aditya Toshniwal < >>> [email protected]> wrote: >>> >>>> Hi Zaid, >>>> >>>> On Fri, Feb 21, 2025 at 4:26 PM Zaid Shabbir <[email protected]> >>>> wrote: >>>> >>>>> Hello Aditya, >>>>> >>>>> The above design looks good to me. We could improve visibility by >>>>> adding vertical and horizontal lines in a combination of blue, gray, and >>>>> black. Blue represents the current active tab, gray indicates a disabled >>>>> tab, and black signifies available clickable options. >>>>> >>>>> e.g. >>>>> >>>>> [image: Sample.png] >>>>> >>>> That doesn't match the pgAdmin design. The colors which you mentioned >>>> are already being used. >>>> >>>>> >>>>> Regards, >>>>> >>>>> Zaid Shabbir >>>>> >>>>> On Fri, Feb 21, 2025 at 3:32 PM Aditya Toshniwal < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Updated design: >>>>>> >>>>>> [image: image.png] >>>>>> >>>>>> On Fri, Feb 21, 2025 at 3:56 PM Aditya Toshniwal < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> On Fri, Feb 21, 2025 at 3:21 PM Dave Page <[email protected]> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Hi Hackers, >>>>>>>>> >>>>>>>>> I've been working on a new feature to restore a plain SQL using >>>>>>>>> the pgAdmin restore dialog. Internally, it will select pg_restore or psql >>>>>>>>> based on the format. >>>>>>>>> >>>>>>>>> Now, when restoring plain format the tabs like Data Options, >>>>>>>>> Query Options are not applicable. So instead of going and disabling all the >>>>>>>>> fields under these tabs, I think we can simply disable the complete tab. >>>>>>>>> >>>>>>>>> I've come up with the following UI design for the disabled tabs. >>>>>>>>> The tabs will enable/disable based on the format selected. >>>>>>>>> >>>>>>>>> Please share your feedback on this. >>>>>>>>> >>>>>>>>> >>>>>>>>> [image: image.png] >>>>>>>>> >>>>>>>> >>>>>>>> Normally when something is disabled, it is simply greyed out and >>>>>>>> made to not respond to input. Why not do the same here instead of designing >>>>>>>> a new way of indicating disabled state? >>>>>>>> >>>>>>> I thought of adding an icon for better accessibility. Greying is >>>>>>> pretty straightforward. >>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>> pgEdge: https://www.pgedge.com >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks, >>>>>>> Aditya Toshniwal >>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>>>>> <https://www.enterprisedb.com/; >>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks, >>>>>> Aditya Toshniwal >>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>>>> <https://www.enterprisedb.com/; >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>> <https://www.enterprisedb.com/; >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >> <https://www.enterprisedb.com/; >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > pgEdge: https://www.pgedge.com > > Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image [image/png] image.png (82.5K, 4-image.png) download | view image [image/png] Sample.png (19.9K, 5-Sample.png) download | view image [image/png] Screenshot 2025-02-21 at 4.29.30 PM.png (105.1K, 6-Screenshot%202025-02-21%20at%204.29.30%20PM.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
* Re: Disabled or Not applicable Tabs design @ 2025-02-22 11:20 Usman Khan <[email protected]> parent: Dave Page <[email protected]> 1 sibling, 0 replies; 12+ messages in thread From: Usman Khan @ 2025-02-22 11:20 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; Zaid Shabbir <[email protected]>; pgadmin-hackers +1 On Fri, Feb 21, 2025 at 4:47 PM Dave Page <[email protected]> wrote: > > > On Fri, 21 Feb 2025 at 11:40, Aditya Toshniwal < > [email protected]> wrote: > >> Hi Zaid, >> >> Changing tab design will need changes in the complete application. It >> also needs to be discussed with everyone before changing it. >> Anyway, it should not be part of the task I'm working on. You can open a >> separate thread for discussions. >> > > Agreed. > > I do think the greyed option is the best way forward, even if there are > potential improvements we could make to the design app-wide. > > >> >> On Fri, Feb 21, 2025 at 5:03 PM Zaid Shabbir <[email protected]> >> wrote: >> >>> Hello, >>> >>> Some other samples for the tabular window. >>> >>> [image: Screenshot 2025-02-21 at 4.29.30 PM.png] >>> >>> Aditiya it's just a suggestion, you can use the most suitable layout and >>> colors. >>> >>> Regards, >>> Zaid Shabbir >>> >>> >>> >>> On Fri, Feb 21, 2025 at 3:59 PM Aditya Toshniwal < >>> [email protected]> wrote: >>> >>>> Hi Zaid, >>>> >>>> On Fri, Feb 21, 2025 at 4:26 PM Zaid Shabbir <[email protected]> >>>> wrote: >>>> >>>>> Hello Aditya, >>>>> >>>>> The above design looks good to me. We could improve visibility by >>>>> adding vertical and horizontal lines in a combination of blue, gray, and >>>>> black. Blue represents the current active tab, gray indicates a disabled >>>>> tab, and black signifies available clickable options. >>>>> >>>>> e.g. >>>>> >>>>> [image: Sample.png] >>>>> >>>> That doesn't match the pgAdmin design. The colors which you mentioned >>>> are already being used. >>>> >>>>> >>>>> Regards, >>>>> >>>>> Zaid Shabbir >>>>> >>>>> On Fri, Feb 21, 2025 at 3:32 PM Aditya Toshniwal < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Updated design: >>>>>> >>>>>> [image: image.png] >>>>>> >>>>>> On Fri, Feb 21, 2025 at 3:56 PM Aditya Toshniwal < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> On Fri, Feb 21, 2025 at 3:21 PM Dave Page <[email protected]> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Hi Hackers, >>>>>>>>> >>>>>>>>> I've been working on a new feature to restore a plain SQL using >>>>>>>>> the pgAdmin restore dialog. Internally, it will select pg_restore or psql >>>>>>>>> based on the format. >>>>>>>>> >>>>>>>>> Now, when restoring plain format the tabs like Data Options, >>>>>>>>> Query Options are not applicable. So instead of going and disabling all the >>>>>>>>> fields under these tabs, I think we can simply disable the complete tab. >>>>>>>>> >>>>>>>>> I've come up with the following UI design for the disabled tabs. >>>>>>>>> The tabs will enable/disable based on the format selected. >>>>>>>>> >>>>>>>>> Please share your feedback on this. >>>>>>>>> >>>>>>>>> >>>>>>>>> [image: image.png] >>>>>>>>> >>>>>>>> >>>>>>>> Normally when something is disabled, it is simply greyed out and >>>>>>>> made to not respond to input. Why not do the same here instead of designing >>>>>>>> a new way of indicating disabled state? >>>>>>>> >>>>>>> I thought of adding an icon for better accessibility. Greying is >>>>>>> pretty straightforward. >>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> pgAdmin: https://www.pgadmin.org >>>>>>>> PostgreSQL: https://www.postgresql.org >>>>>>>> pgEdge: https://www.pgedge.com >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks, >>>>>>> Aditya Toshniwal >>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>>>>> <https://www.enterprisedb.com/; >>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks, >>>>>> Aditya Toshniwal >>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>>>> <https://www.enterprisedb.com/; >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >>>> <https://www.enterprisedb.com/; >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com* >> <https://www.enterprisedb.com/; >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > pgEdge: https://www.pgedge.com > > Attachments: [image/png] image.png (65.5K, 3-image.png) download | view image [image/png] image.png (82.5K, 4-image.png) download | view image [image/png] Sample.png (19.9K, 5-Sample.png) download | view image [image/png] Screenshot 2025-02-21 at 4.29.30 PM.png (105.1K, 6-Screenshot%202025-02-21%20at%204.29.30%20PM.png) download | view image ^ permalink raw reply [nested|flat] 12+ messages in thread
end of thread, other threads:[~2025-02-22 11:20 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-02-21 09:37 Disabled or Not applicable Tabs design Aditya Toshniwal <[email protected]> 2025-02-21 09:50 ` Dave Page <[email protected]> 2025-02-21 10:11 ` Zaid Shabbir <[email protected]> 2025-02-21 10:26 ` Aditya Toshniwal <[email protected]> 2025-02-21 10:31 ` Aditya Toshniwal <[email protected]> 2025-02-21 10:55 ` Zaid Shabbir <[email protected]> 2025-02-21 10:58 ` Aditya Toshniwal <[email protected]> 2025-02-21 11:33 ` Zaid Shabbir <[email protected]> 2025-02-21 11:40 ` Aditya Toshniwal <[email protected]> 2025-02-21 11:47 ` Dave Page <[email protected]> 2025-02-22 11:18 ` Usman Khan <[email protected]> 2025-02-22 11:20 ` Usman Khan <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox